Set default deep value false in Document.importNode

Set default deep value false in Document.importNode

spec: http://dom.spec.whatwg.org/#interface-document
According to spec, optional second parameter(deep)
has default false value.

So this CL modified it as per specified.

TEST=LayoutTests/fast/dom/document-importNode-arguments.html

In addition, with this CL,
No 'deep' argument test at
http://w3c-test.org/dom/nodes/Document-importNode.html will be passed.

Behavior in other browsers.
*)FF: PASS
*)IE: FAIL

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178887

[kangil_, 2014-07-05 03:14:00]

PTAL

[haraken, 2014-07-05 03:57:43]

https://codereview.chromium.org/371693002/diff/1/LayoutTests/fast/dom/documen...
File LayoutTests/fast/dom/document-importNode-arguments-expected.txt (left):

https://codereview.chromium.org/371693002/diff/1/LayoutTests/fast/dom/documen...
LayoutTests/fast/dom/document-importNode-arguments-expected.txt:1: CONSOLE
WARNING: The behavior of importNode() with no boolean argument is about to
change from doing a deep clone to doing a shallow clone.  Make sure to pass an
explicit boolean argument to keep your current behavior.

This console message indicates that someone is intending to make this change in
a conservative manner (i.e., first add a console message for developers, and
then make the change) for some reason.

Would you blame the git history and ask the author of the console message about
the intention?

Also if we decide to make this change, we should remove the console message in
this CL.

[kangil_, 2014-07-05 04:00:32]

https://codereview.chromium.org/371693002/diff/1/LayoutTests/fast/dom/documen...
File LayoutTests/fast/dom/document-importNode-arguments-expected.txt (left):

https://codereview.chromium.org/371693002/diff/1/LayoutTests/fast/dom/documen...
LayoutTests/fast/dom/document-importNode-arguments-expected.txt:1: CONSOLE
WARNING: The behavior of importNode() with no boolean argument is about to
change from doing a deep clone to doing a shallow clone.  Make sure to pass an
explicit boolean argument to keep your current behavior.
On 2014/07/05 03:57:42, haraken wrote:
> 
> This console message indicates that someone is intending to make this change
in
> a conservative manner (i.e., first add a console message for developers, and
> then make the change) for some reason.
> 
> Would you blame the git history and ask the author of the console message
about
> the intention?
> 
> Also if we decide to make this change, we should remove the console message in
> this CL.

Sure I will check.

[kangil_, 2014-07-05 05:03:32]

On 2014/07/05 04:00:32, kangil_ wrote:
>
https://codereview.chromium.org/371693002/diff/1/LayoutTests/fast/dom/documen...
> File LayoutTests/fast/dom/document-importNode-arguments-expected.txt (left):
> 
>
https://codereview.chromium.org/371693002/diff/1/LayoutTests/fast/dom/documen...
> LayoutTests/fast/dom/document-importNode-arguments-expected.txt:1: CONSOLE
> WARNING: The behavior of importNode() with no boolean argument is about to
> change from doing a deep clone to doing a shallow clone.  Make sure to pass an
> explicit boolean argument to keep your current behavior.
> On 2014/07/05 03:57:42, haraken wrote:
> > 
> > This console message indicates that someone is intending to make this change
> in
> > a conservative manner (i.e., first add a console message for developers, and
> > then make the change) for some reason.
> > 
> > Would you blame the git history and ask the author of the console message
> about
> > the intention?
> > 
> > Also if we decide to make this change, we should remove the console message
in
> > this CL.
> 
> Sure I will check.

Console message was added by https://codereview.chromium.org/252713004/
According to the review comments at that pointer,
FF enabled default deep argument in nightly build at the time.
However, currently released FF 30 doesn't show any console message.
So, IMHO, we can delete console message also.

Thanks for the review comment and PTAL!

[haraken, 2014-07-05 06:08:49]

rob, arv: Are you fine with this change?

[Inactive, 2014-07-05 11:50:36]

On 2014/07/05 06:08:49, haraken wrote:
> rob, arv: Are you fine with this change?

Is the usage low enough according to the use counter? Has it made it to a stable
release already? Rob did not add it that long ago iirc.

[kangil_, 2014-07-05 14:08:21]

On 2014/07/05 11:50:36, OOO until July 9 wrote:
> On 2014/07/05 06:08:49, haraken wrote:
> > rob, arv: Are you fine with this change?

> Is the usage low enough according to the use counter?
Yes, it is. Dashboard shows it as '<=0.0001%'

> Has it made it to a stable release already?
No, it hasn't. m35 doesn't emit console message.

[rwlbuis, 2014-07-07 15:16:30]

On 2014/07/05 06:08:49, haraken wrote:
> rob, arv: Are you fine with this change?

Fine with me technically, I just don't know if it is too early or not.

[tkent, 2014-07-08 00:03:40]

On 2014/07/05 14:08:21, kangil_ wrote:
> On 2014/07/05 11:50:36, OOO until July 9 wrote:
> > On 2014/07/05 06:08:49, haraken wrote:
> > > rob, arv: Are you fine with this change?
> 
> > Is the usage low enough according to the use counter?
> Yes, it is. Dashboard shows it as '<=0.0001%'
> 
> > Has it made it to a stable release already?
> No, it hasn't. m35 doesn't emit console message.

Then, the dashboard data is not reliable yet.
This change is too early.

[kangil_, 2014-07-08 00:33:14]

On 2014/07/08 00:03:40, tkent wrote:
> On 2014/07/05 14:08:21, kangil_ wrote:
> > On 2014/07/05 11:50:36, OOO until July 9 wrote:
> > > On 2014/07/05 06:08:49, haraken wrote:
> > > > rob, arv: Are you fine with this change?
> > 
> > > Is the usage low enough according to the use counter?
> > Yes, it is. Dashboard shows it as '<=0.0001%'
> > 
> > > Has it made it to a stable release already?
> > No, it hasn't. m35 doesn't emit console message.
> 
> Then, the dashboard data is not reliable yet.
> This change is too early.

Got it.
Holding this patch till spec become mature.

[kangil_, 2014-07-22 01:29:55]

For the record, m36(36.0.1985.125) stable release displays warning message on
console.

[tkent, 2014-07-25 00:46:38]

> For the record, m36(36.0.1985.125) stable release displays warning message on
> console.

http://www.chromestatus.com/metrics/feature/timeline/popularity/373
ok, 0.0003% looks safe to change the behavior.  lgtm.

[tkent, 2014-07-25 00:46:52]

The CQ bit was checked by tkent@chromium.org

[commit-bot: I haz the power, 2014-07-25 00:47:28]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/kangil.han@samsung.com/371693002/40001

[commit-bot: I haz the power, 2014-07-25 01:50:21]

Change committed as 178887