Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 371693002: Set default deep value false in Document.importNode (Closed)

Created:
6 years, 5 months ago by kangil_
Modified:
6 years, 5 months ago
CC:
blink-reviews, arv+blink, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, watchdog-blink-watchlist_google.com
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Set default deep value false in Document.importNode spec: http://dom.spec.whatwg.org/#interface-document According to spec, optional second parameter(deep) has default false value. So this CL modified it as per specified. TEST=LayoutTests/fast/dom/document-importNode-arguments.html In addition, with this CL, No 'deep' argument test at http://w3c-test.org/dom/nodes/Document-importNode.html will be passed. Behavior in other browsers. *)FF: PASS *)IE: FAIL Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178887

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix fast/xpath/xpath-detached-import-assert.html test #

Patch Set 3 : Take review comment into consideration #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -20 lines) Patch
M LayoutTests/fast/dom/document-importNode-arguments.html View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/dom/document-importNode-arguments-expected.txt View 1 chunk +2 lines, -3 lines 0 comments Download
M LayoutTests/fast/dom/importNode-unsupported-node-type-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/xpath/xpath-detached-import-assert-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/dom/Document.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/dom/Document.cpp View 1 2 1 chunk +0 lines, -6 lines 0 comments Download
M Source/core/dom/Document.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/UseCounter.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/frame/UseCounter.cpp View 1 2 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
kangil_
PTAL
6 years, 5 months ago (2014-07-05 03:14:00 UTC) #1
haraken
https://codereview.chromium.org/371693002/diff/1/LayoutTests/fast/dom/document-importNode-arguments-expected.txt File LayoutTests/fast/dom/document-importNode-arguments-expected.txt (left): https://codereview.chromium.org/371693002/diff/1/LayoutTests/fast/dom/document-importNode-arguments-expected.txt#oldcode1 LayoutTests/fast/dom/document-importNode-arguments-expected.txt:1: CONSOLE WARNING: The behavior of importNode() with no boolean ...
6 years, 5 months ago (2014-07-05 03:57:43 UTC) #2
kangil_
https://codereview.chromium.org/371693002/diff/1/LayoutTests/fast/dom/document-importNode-arguments-expected.txt File LayoutTests/fast/dom/document-importNode-arguments-expected.txt (left): https://codereview.chromium.org/371693002/diff/1/LayoutTests/fast/dom/document-importNode-arguments-expected.txt#oldcode1 LayoutTests/fast/dom/document-importNode-arguments-expected.txt:1: CONSOLE WARNING: The behavior of importNode() with no boolean ...
6 years, 5 months ago (2014-07-05 04:00:32 UTC) #3
kangil_
On 2014/07/05 04:00:32, kangil_ wrote: > https://codereview.chromium.org/371693002/diff/1/LayoutTests/fast/dom/document-importNode-arguments-expected.txt > File LayoutTests/fast/dom/document-importNode-arguments-expected.txt (left): > > https://codereview.chromium.org/371693002/diff/1/LayoutTests/fast/dom/document-importNode-arguments-expected.txt#oldcode1 > ...
6 years, 5 months ago (2014-07-05 05:03:32 UTC) #4
haraken
rob, arv: Are you fine with this change?
6 years, 5 months ago (2014-07-05 06:08:49 UTC) #5
Inactive
On 2014/07/05 06:08:49, haraken wrote: > rob, arv: Are you fine with this change? Is ...
6 years, 5 months ago (2014-07-05 11:50:36 UTC) #6
kangil_
On 2014/07/05 11:50:36, OOO until July 9 wrote: > On 2014/07/05 06:08:49, haraken wrote: > ...
6 years, 5 months ago (2014-07-05 14:08:21 UTC) #7
rwlbuis
On 2014/07/05 06:08:49, haraken wrote: > rob, arv: Are you fine with this change? Fine ...
6 years, 5 months ago (2014-07-07 15:16:30 UTC) #8
tkent
On 2014/07/05 14:08:21, kangil_ wrote: > On 2014/07/05 11:50:36, OOO until July 9 wrote: > ...
6 years, 5 months ago (2014-07-08 00:03:40 UTC) #9
kangil_
On 2014/07/08 00:03:40, tkent wrote: > On 2014/07/05 14:08:21, kangil_ wrote: > > On 2014/07/05 ...
6 years, 5 months ago (2014-07-08 00:33:14 UTC) #10
kangil_
For the record, m36(36.0.1985.125) stable release displays warning message on console.
6 years, 5 months ago (2014-07-22 01:29:55 UTC) #11
tkent
> For the record, m36(36.0.1985.125) stable release displays warning message on > console. http://www.chromestatus.com/metrics/feature/timeline/popularity/373 ok, ...
6 years, 5 months ago (2014-07-25 00:46:38 UTC) #12
tkent
The CQ bit was checked by tkent@chromium.org
6 years, 5 months ago (2014-07-25 00:46:52 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kangil.han@samsung.com/371693002/40001
6 years, 5 months ago (2014-07-25 00:47:28 UTC) #14
commit-bot: I haz the power
6 years, 5 months ago (2014-07-25 01:50:21 UTC) #15
Message was sent while issue was closed.
Change committed as 178887

Powered by Google App Engine
This is Rietveld 408576698