Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Side by Side Diff: Source/core/dom/Document.cpp

Issue 371693002: Set default deep value false in Document.importNode (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Take review comment into consideration Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/dom/Document.h ('k') | Source/core/dom/Document.idl » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * (C) 2006 Alexey Proskuryakov (ap@webkit.org) 5 * (C) 2006 Alexey Proskuryakov (ap@webkit.org)
6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2011, 2012 Apple Inc. All r ights reserved. 6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2011, 2012 Apple Inc. All r ights reserved.
7 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/) 7 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/)
8 * Copyright (C) 2008, 2009, 2011, 2012 Google Inc. All rights reserved. 8 * Copyright (C) 2008, 2009, 2011, 2012 Google Inc. All rights reserved.
9 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies) 9 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies)
10 * Copyright (C) Research In Motion Limited 2010-2011. All rights reserved. 10 * Copyright (C) Research In Motion Limited 2010-2011. All rights reserved.
(...skipping 917 matching lines...) Expand 10 before | Expand all | Expand 10 after
928 if (exceptionState.hadException()) 928 if (exceptionState.hadException())
929 return false; 929 return false;
930 newContainerNode->appendChild(newChild.release(), exceptionState); 930 newContainerNode->appendChild(newChild.release(), exceptionState);
931 if (exceptionState.hadException()) 931 if (exceptionState.hadException())
932 return false; 932 return false;
933 } 933 }
934 934
935 return true; 935 return true;
936 } 936 }
937 937
938 PassRefPtrWillBeRawPtr<Node> Document::importNode(Node* importedNode, ExceptionS tate& ec)
939 {
940 UseCounter::countDeprecation(this, UseCounter::DocumentImportNodeOptionalArg ument);
941 return importNode(importedNode, true, ec);
942 }
943
944 PassRefPtrWillBeRawPtr<Node> Document::importNode(Node* importedNode, bool deep, ExceptionState& exceptionState) 938 PassRefPtrWillBeRawPtr<Node> Document::importNode(Node* importedNode, bool deep, ExceptionState& exceptionState)
945 { 939 {
946 switch (importedNode->nodeType()) { 940 switch (importedNode->nodeType()) {
947 case TEXT_NODE: 941 case TEXT_NODE:
948 return createTextNode(importedNode->nodeValue()); 942 return createTextNode(importedNode->nodeValue());
949 case CDATA_SECTION_NODE: 943 case CDATA_SECTION_NODE:
950 return CDATASection::create(*this, importedNode->nodeValue()); 944 return CDATASection::create(*this, importedNode->nodeValue());
951 case PROCESSING_INSTRUCTION_NODE: 945 case PROCESSING_INSTRUCTION_NODE:
952 return createProcessingInstruction(importedNode->nodeName(), importedNod e->nodeValue(), exceptionState); 946 return createProcessingInstruction(importedNode->nodeName(), importedNod e->nodeValue(), exceptionState);
953 case COMMENT_NODE: 947 case COMMENT_NODE:
(...skipping 4865 matching lines...) Expand 10 before | Expand all | Expand 10 after
5819 visitor->trace(m_compositorPendingAnimations); 5813 visitor->trace(m_compositorPendingAnimations);
5820 visitor->trace(m_contextDocument); 5814 visitor->trace(m_contextDocument);
5821 visitor->registerWeakMembers<Document, &Document::clearWeakMembers>(this); 5815 visitor->registerWeakMembers<Document, &Document::clearWeakMembers>(this);
5822 DocumentSupplementable::trace(visitor); 5816 DocumentSupplementable::trace(visitor);
5823 TreeScope::trace(visitor); 5817 TreeScope::trace(visitor);
5824 ContainerNode::trace(visitor); 5818 ContainerNode::trace(visitor);
5825 ExecutionContext::trace(visitor); 5819 ExecutionContext::trace(visitor);
5826 } 5820 }
5827 5821
5828 } // namespace WebCore 5822 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/core/dom/Document.h ('k') | Source/core/dom/Document.idl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698