LayoutTests/fast/dom/document-importNode-arguments-expected.txt - Issue 371693002: Set default deep value false in Document.importNode

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/dom/document-importNode-arguments-expected.txt

Issue 371693002: Set default deep value false in Document.importNode (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « LayoutTests/fast/dom/document-importNode-arguments.html ('k') | LayoutTests/fast/dom/importNode-unsupported-node-type-expected.txt » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 CONSOLE WARNING: The behavior of importNode() with no boolean argument is about to change from doing a deep clone to doing a shallow clone. Make sure to pass a n explicit boolean argument to keep your current behavior.
haraken 2014/07/05 03:57:42 This console message indicates that someone is int This console message indicates that someone is intending to make this change in a conservative manner (i.e., first add a console message for developers, and then make the change) for some reason. Would you blame the git history and ask the author of the console message about the intention? Also if we decide to make this change, we should remove the console message in this CL. kangil_ 2014/07/05 04:00:32 Sure I will check. Show quoted text On 2014/07/05 03:57:42, haraken wrote: > > This console message indicates that someone is intending to make this change in > a conservative manner (i.e., first add a console message for developers, and > then make the change) for some reason. > > Would you blame the git history and ask the author of the console message about > the intention? > > Also if we decide to make this change, we should remove the console message in > this CL. Sure I will check.
2 This page tests calling document.importNode.	1 This page tests calling document.importNode.

3	2

4 PASS imported.childNodes.length is 2	3 PASS imported.childNodes.length is 0

5 PASS imported.textContent == 'hello world' is true	4 PASS imported.textContent == '' is true

6 PASS imported.childNodes.length is 2	5 PASS imported.childNodes.length is 2

7 PASS imported.textContent == 'hello world' is true	6 PASS imported.textContent == 'hello world' is true

8 PASS imported.childNodes.length is 0	7 PASS imported.childNodes.length is 0

9 PASS imported.textContent == '' is true	8 PASS imported.textContent == '' is true

10 PASS successfullyParsed is true	9 PASS successfullyParsed is true

11	10

12 TEST COMPLETE	11 TEST COMPLETE

13	12

OLD	NEW