LayoutTests/fast/xpath/xpath-detached-import-assert-expected.txt - Issue 371693002: Set default deep value false in Document.importNode

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/xpath/xpath-detached-import-assert-expected.txt

Issue 371693002: Set default deep value false in Document.importNode (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Take review comment into consideration Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 CONSOLE WARNING: The behavior of importNode() with no boolean argument is about to change from doing a deep clone to doing a shallow clone. Make sure to pass a n explicit boolean argument to keep your current behavior.

2 A test case from https://bugs.webkit.org/show_bug.cgi?id=84793.	1 A test case from https://bugs.webkit.org/show_bug.cgi?id=84793.

3	2

4 Test passes if it doesn't hit ASSERT(parents.size() >= depth + 1).	3 Test passes if it doesn't hit ASSERT(parents.size() >= depth + 1).

5	4

6 PASS result.numberValue is NaN	5 PASS result.numberValue is NaN

7 PASS successfullyParsed is true	6 PASS successfullyParsed is true

8	7

9 TEST COMPLETE	8 TEST COMPLETE

10	9

OLD	NEW

« no previous file with comments | « LayoutTests/fast/dom/importNode-unsupported-node-type-expected.txt ('k') | Source/core/dom/Document.h » ('j') | no next file with comments »