Source/core/dom/Document.idl - Issue 371693002: Set default deep value false in Document.importNode

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/Document.idl

Issue 371693002: Set default deep value false in Document.importNode (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Take review comment into consideration Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/dom/Document.idl

diff --git a/Source/core/dom/Document.idl b/Source/core/dom/Document.idl

index 6dedbc9982428254cb06363e31fe60188ffdcde1..0fb8ee689d0ddc04c266131d4a8135fd101f5536 100644

--- a/Source/core/dom/Document.idl

+++ b/Source/core/dom/Document.idl

@@ -42,7 +42,7 @@ typedef (CanvasRenderingContext2D or WebGLRenderingContext) RenderingContext;

// Introduced in DOM Level 2:

- [CustomElementCallbacks, RaisesException, TypeChecking=Interface] Node importNode(Node node, optional boolean deep);

+ [CustomElementCallbacks, RaisesException, TypeChecking=Interface] Node importNode(Node node, optional boolean deep = false);

[CustomElementCallbacks, RaisesException] Element createElementNS(DOMString? namespaceURI, DOMString qualifiedName);

[RaisesException, DeprecateAs=DocumentCreateAttributeNS] Attr createAttributeNS([Default=Undefined] optional DOMString? namespaceURI,

[Default=Undefined] optional DOMString? qualifiedName); // Removed from DOM4.

« no previous file with comments | « Source/core/dom/Document.cpp ('k') | Source/core/frame/UseCounter.h » ('j') | no next file with comments »