Source/core/dom/Document.h - Issue 371693002: Set default deep value false in Document.importNode

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/Document.h

Issue 371693002: Set default deep value false in Document.importNode (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Take review comment into consideration Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/dom/Document.h

diff --git a/Source/core/dom/Document.h b/Source/core/dom/Document.h

index 397330e780aedd694d8034a27b4c2cf531962d9f..1ac0e17287850eed4b5c61b8db97e5d31f1fb236 100644

--- a/Source/core/dom/Document.h

+++ b/Source/core/dom/Document.h

@@ -310,7 +310,6 @@ public:

PassRefPtrWillBeRawPtr<ProcessingInstruction> createProcessingInstruction(const String& target, const String& data, ExceptionState&);

PassRefPtrWillBeRawPtr<Attr> createAttribute(const AtomicString& name, ExceptionState&);

PassRefPtrWillBeRawPtr<Attr> createAttributeNS(const AtomicString& namespaceURI, const AtomicString& qualifiedName, ExceptionState&, bool shouldIgnoreNamespaceChecks = false);

- PassRefPtrWillBeRawPtr<Node> importNode(Node* importedNode, ExceptionState&);

PassRefPtrWillBeRawPtr<Node> importNode(Node* importedNode, bool deep, ExceptionState&);

PassRefPtrWillBeRawPtr<Element> createElementNS(const AtomicString& namespaceURI, const AtomicString& qualifiedName, ExceptionState&);

PassRefPtrWillBeRawPtr<Element> createElement(const QualifiedName&, bool createdByParser);

« no previous file with comments | « LayoutTests/fast/xpath/xpath-detached-import-assert-expected.txt ('k') | Source/core/dom/Document.cpp » ('j') | no next file with comments »