Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Side by Side Diff: Source/core/frame/UseCounter.cpp

Issue 371693002: Set default deep value false in Document.importNode (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Take review comment into consideration Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/frame/UseCounter.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 1
2 /* 2 /*
3 * Copyright (C) 2012 Google, Inc. All rights reserved. 3 * Copyright (C) 2012 Google, Inc. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 715 matching lines...) Expand 10 before | Expand all | Expand 10 after
726 726
727 case NodeIteratorExpandEntityReferences: 727 case NodeIteratorExpandEntityReferences:
728 return "'NodeIterator.expandEntityReferences' is deprecated and has been removed from DOM. It always returns false."; 728 return "'NodeIterator.expandEntityReferences' is deprecated and has been removed from DOM. It always returns false.";
729 729
730 case TreeWalkerExpandEntityReferences: 730 case TreeWalkerExpandEntityReferences:
731 return "'TreeWalker.expandEntityReferences' is deprecated and has been r emoved from DOM. It always returns false."; 731 return "'TreeWalker.expandEntityReferences' is deprecated and has been r emoved from DOM. It always returns false.";
732 732
733 case RangeDetach: 733 case RangeDetach:
734 return "'Range.detach' is now a no-op, as per DOM (http://dom.spec.whatw g.org/#dom-range-detach)."; 734 return "'Range.detach' is now a no-op, as per DOM (http://dom.spec.whatw g.org/#dom-range-detach).";
735 735
736 case DocumentImportNodeOptionalArgument:
737 return "The behavior of importNode() with no boolean argument is about t o change from doing a deep clone to doing a shallow clone. "
738 "Make sure to pass an explicit boolean argument to keep your current behavior.";
739
740 case OverflowChangedEvent: 736 case OverflowChangedEvent:
741 return "The 'overflowchanged' event is deprecated and may be removed. Pl ease do not use it."; 737 return "The 'overflowchanged' event is deprecated and may be removed. Pl ease do not use it.";
742 738
743 case HTMLHeadElementProfile: 739 case HTMLHeadElementProfile:
744 return "'HTMLHeadElement.profile' is deprecated. The reflected attribute has no effect."; 740 return "'HTMLHeadElement.profile' is deprecated. The reflected attribute has no effect.";
745 741
746 case ElementSetPrefix: 742 case ElementSetPrefix:
747 return "Setting 'Element.prefix' is deprecated, as it is read-only per D OM (http://dom.spec.whatwg.org/#element)."; 743 return "Setting 'Element.prefix' is deprecated, as it is read-only per D OM (http://dom.spec.whatwg.org/#element).";
748 744
749 case SyncXHRWithCredentials: 745 case SyncXHRWithCredentials:
(...skipping 40 matching lines...) Expand 10 before | Expand all | Expand 10 after
790 UseCounter* UseCounter::getFrom(const StyleSheetContents* sheetContents) 786 UseCounter* UseCounter::getFrom(const StyleSheetContents* sheetContents)
791 { 787 {
792 // FIXME: We may want to handle stylesheets that have multiple owners 788 // FIXME: We may want to handle stylesheets that have multiple owners
793 // http://crbug.com/242125 789 // http://crbug.com/242125
794 if (sheetContents && sheetContents->hasSingleOwnerNode()) 790 if (sheetContents && sheetContents->hasSingleOwnerNode())
795 return getFrom(sheetContents->singleOwnerDocument()); 791 return getFrom(sheetContents->singleOwnerDocument());
796 return 0; 792 return 0;
797 } 793 }
798 794
799 } // namespace WebCore 795 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/core/frame/UseCounter.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698