Issue 365783002: Autofill: don't require POST method.

Issue 365783002: Autofill: don't require POST method. (Closed)

Created:
6 years, 5 months ago by Evan Stade

Modified:
6 years, 5 months ago

Reviewers:
vabr (Chromium), Ilya Sherman

CC:
chromium-reviews, benquan, browser-components-watch_chromium.org, Dane Wallinga, dyu1, estade+watch_chromium.org, Ilya Sherman, rouslan+autofillwatch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Autofill: don't require POST method. This removes the restriction that forms must have method="POST" to be autofilled. FormData no longer tracks the method at all. BUG=390713 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283347

Patch Set 1 #

Patch Set 2 : nuke more #

Patch Set 3 : finish him #

Patch Set 4 : remove test expectation #

Total comments: 2

Patch Set 5 : remove method_ member #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+47 lines, -259 lines)			Patch
M	chrome/browser/ui/autofill/autofill_dialog_controller_browsertest.cc	View	1 2	1 chunk	+0 lines, -1 line	0 comments	Download
M	components/autofill/content/common/autofill_param_traits_macros.h	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	components/autofill/content/renderer/form_autofill_util.cc	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	components/autofill/content/renderer/password_autofill_agent.cc	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	components/autofill/core/browser/autocomplete_history_manager_unittest.cc	View	1	5 chunks	+0 lines, -5 lines	0 comments	Download
M	components/autofill/core/browser/autofill_download_unittest.cc	View	1	2 chunks	+0 lines, -2 lines	0 comments	Download
M	components/autofill/core/browser/autofill_manager.cc	View	1	6 chunks	+6 lines, -6 lines	0 comments	Download
M	components/autofill/core/browser/autofill_manager_unittest.cc	View	1 2	12 chunks	+0 lines, -69 lines	0 comments	Download
M	components/autofill/core/browser/autofill_merge_unittest.cc	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	components/autofill/core/browser/autofill_metrics_unittest.cc	View	1	7 chunks	+0 lines, -7 lines	0 comments	Download
M	components/autofill/core/browser/autofill_test_utils.cc	View	1 2	1 chunk	+0 lines, -1 line	0 comments	Download
M	components/autofill/core/browser/form_structure.h	View	1 2 3 4	4 chunks	+3 lines, -14 lines	0 comments	Download
M	components/autofill/core/browser/form_structure.cc	View	1	8 chunks	+6 lines, -22 lines	0 comments	Download
M	components/autofill/core/browser/form_structure_unittest.cc	View	1 2	60 chunks	+32 lines, -84 lines	0 comments	Download
M	components/autofill/core/common/autofill_data_validation.cc	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	components/autofill/core/common/form_data.h	View	1	1 chunk	+0 lines, -2 lines	0 comments	Download
M	components/autofill/core/common/form_data.cc	View	1	6 chunks	+0 lines, -7 lines	0 comments	Download
M	components/autofill/core/common/form_data_unittest.cc	View	1 2	1 chunk	+0 lines, -1 line	0 comments	Download
M	components/autofill/core/common/save_password_progress_logger.h	View	1	2 chunks	+0 lines, -5 lines	0 comments	Download
M	components/autofill/core/common/save_password_progress_logger.cc	View	1	3 chunks	+0 lines, -25 lines	0 comments	Download
M	components/autofill/core/common/save_password_progress_logger_unittest.cc	View	1 2 3	1 chunk	+0 lines, -2 lines	0 comments	Download
M	components/password_manager/core/browser/login_database_unittest.cc	View	1 2	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

Evan Stade

+vabr for components/password_manager/core/browser/login_database_unittest.cc +ilya for the rest

6 years, 5 months ago (2014-07-14 23:38:26 UTC) #1

Ilya Sherman

LGTM. Thanks, Evan! Václav, you might want to also take a look at the SavePasswordProgressLogger ...

6 years, 5 months ago (2014-07-15 03:21:24 UTC) #2

vabr (Chromium)

I second Ilya's comment about FormStructure::method_. Other than that, everything LGTM, in particular changes in ...

6 years, 5 months ago (2014-07-15 08:12:05 UTC) #3

Evan Stade

https://codereview.chromium.org/365783002/diff/60001/components/autofill/core/browser/form_structure.h File components/autofill/core/browser/form_structure.h (right): https://codereview.chromium.org/365783002/diff/60001/components/autofill/core/browser/form_structure.h#newcode250 components/autofill/core/browser/form_structure.h:250: base::string16 method_; On 2014/07/15 03:21:24, Ilya Sherman wrote: > ...

6 years, 5 months ago (2014-07-15 19:01:57 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/365783002/80001

6 years, 5 months ago (2014-07-15 19:05:09 UTC) #6

Message was sent while issue was closed.

Change committed as 283347

Expand Messages | Collapse Messages