Autofill: don't require POST method.

components/autofill/core/common/save_password_progress_logger.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/autofill/core/common/save_password_progress_logger.h"
 
 #include <algorithm>
 
 #include "base/json/json_writer.h"
 #include "base/logging.h"
@@ skipping 21 matching lines @@
 // is not open), that optimizing for code robustness is preferred against speed.
 // Note 2: The messages can be used as dictionary keys. Do not use '.' in them.
 std::string GetStringFromID(SavePasswordProgressLogger::StringID id) {
   switch (id) {
     case SavePasswordProgressLogger::STRING_DECISION_ASK:
       return "Decision: ASK the user";
     case SavePasswordProgressLogger::STRING_DECISION_DROP:
       return "Decision: DROP the password";
     case SavePasswordProgressLogger::STRING_DECISION_SAVE:
       return "Decision: SAVE the password";
-    case SavePasswordProgressLogger::STRING_METHOD:
-      return "Form method";
-    case SavePasswordProgressLogger::STRING_METHOD_GET:
-      return "GET";
-    case SavePasswordProgressLogger::STRING_METHOD_POST:
-      return "POST";
-    case SavePasswordProgressLogger::STRING_METHOD_EMPTY:
-      return "(empty)";
     case SavePasswordProgressLogger::STRING_OTHER:
       return "(other)";
     case SavePasswordProgressLogger::STRING_SCHEME_HTML:
       return "HTML";
     case SavePasswordProgressLogger::STRING_SCHEME_BASIC:
       return "Basic";
     case SavePasswordProgressLogger::STRING_SCHEME_DIGEST:
       return "Digest";
     case SavePasswordProgressLogger::STRING_SCHEME_MESSAGE:
       return "Scheme";
@@ skipping 156 matching lines @@
     case PasswordForm::SCHEME_DIGEST:
       result_id = SavePasswordProgressLogger::STRING_SCHEME_DIGEST;
       break;
     case PasswordForm::SCHEME_OTHER:
       result_id = SavePasswordProgressLogger::STRING_OTHER;
       break;
   }
   return GetStringFromID(result_id);
 }
 
-std::string FormMethodToString(const std::string& method) {
-  std::string method_processed;
-  base::TrimWhitespaceASCII(
-      StringToLowerASCII(method), base::TRIM_ALL, &method_processed);
-  SavePasswordProgressLogger::StringID result_id =
-      SavePasswordProgressLogger::STRING_OTHER;
-  if (method_processed.empty())
-    result_id = SavePasswordProgressLogger::STRING_METHOD_EMPTY;
-  else if (method_processed == "get")
-    result_id = SavePasswordProgressLogger::STRING_METHOD_GET;
-  else if (method_processed == "post")
-    result_id = SavePasswordProgressLogger::STRING_METHOD_POST;
-  return GetStringFromID(result_id);
-}
-
 }  // namespace
 
 SavePasswordProgressLogger::SavePasswordProgressLogger() {
 }
 
 SavePasswordProgressLogger::~SavePasswordProgressLogger() {
 }
 
 void SavePasswordProgressLogger::LogPasswordForm(
     SavePasswordProgressLogger::StringID label,
@@ skipping 23 matching lines @@
   log.SetInteger(GetStringFromID(STRING_TIMES_USED), form.times_used);
   log.SetBoolean(GetStringFromID(STRING_USE_ADDITIONAL_AUTHENTICATION),
                  form.use_additional_authentication);
   log.SetBoolean(GetStringFromID(STRING_PSL_MATCH), form.IsPublicSuffixMatch());
   LogValue(label, log);
 }
 
 void SavePasswordProgressLogger::LogHTMLForm(
     SavePasswordProgressLogger::StringID label,
     const std::string& name_or_id,
-    const std::string& method,
     const GURL& action) {
   DictionaryValue log;
   log.SetString(GetStringFromID(STRING_NAME_OR_ID), ScrubElementID(name_or_id));
-  log.SetString(GetStringFromID(STRING_METHOD), FormMethodToString(method));
   log.SetString(GetStringFromID(STRING_ACTION), ScrubURL(action));
   LogValue(label, log);
 }
 
 void SavePasswordProgressLogger::LogURL(
     SavePasswordProgressLogger::StringID label,
     const GURL& url) {
   LogValue(label, StringValue(ScrubURL(url)));
 }
 
@@ skipping 23 matching lines @@
 
 void SavePasswordProgressLogger::LogValue(StringID label, const Value& log) {
   std::string log_string;
   bool conversion_to_string_successful = base::JSONWriter::WriteWithOptions(
       &log, base::JSONWriter::OPTIONS_PRETTY_PRINT, &log_string);
   DCHECK(conversion_to_string_successful);
   SendLog(GetStringFromID(label) + ": " + log_string);
 }
 
 }  // namespace autofill