Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1183)

Unified Diff: components/autofill/core/common/form_data.cc

Issue 365783002: Autofill: don't require POST method. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: remove method_ member Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/autofill/core/common/form_data.h ('k') | components/autofill/core/common/form_data_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/autofill/core/common/form_data.cc
diff --git a/components/autofill/core/common/form_data.cc b/components/autofill/core/common/form_data.cc
index 3adc4c33927cf1bef0176f1d96862b12d918d23c..83d8173ace00f9c67b7a8689f826fc1e13a05cff 100644
--- a/components/autofill/core/common/form_data.cc
+++ b/components/autofill/core/common/form_data.cc
@@ -56,7 +56,6 @@ FormData::FormData()
FormData::FormData(const FormData& data)
: name(data.name),
- method(data.method),
origin(data.origin),
action(data.action),
user_submitted(data.user_submitted),
@@ -68,7 +67,6 @@ FormData::~FormData() {
bool FormData::operator==(const FormData& form) const {
return name == form.name &&
- StringToLowerASCII(method) == StringToLowerASCII(form.method) &&
origin == form.origin &&
action == form.action &&
user_submitted == form.user_submitted &&
@@ -82,8 +80,6 @@ bool FormData::operator!=(const FormData& form) const {
bool FormData::operator<(const FormData& form) const {
if (name != form.name)
return name < form.name;
- if (StringToLowerASCII(method) != StringToLowerASCII(form.method))
- return StringToLowerASCII(method) < StringToLowerASCII(form.method);
if (origin != form.origin)
return origin < form.origin;
if (action != form.action)
@@ -95,7 +91,6 @@ bool FormData::operator<(const FormData& form) const {
std::ostream& operator<<(std::ostream& os, const FormData& form) {
os << base::UTF16ToUTF8(form.name) << " "
- << base::UTF16ToUTF8(form.method) << " "
<< form.origin << " "
<< form.action << " "
<< form.user_submitted << " "
@@ -109,7 +104,6 @@ std::ostream& operator<<(std::ostream& os, const FormData& form) {
void SerializeFormData(const FormData& form_data, Pickle* pickle) {
pickle->WriteInt(kPickleVersion);
pickle->WriteString16(form_data.name);
- pickle->WriteString16(form_data.method);
pickle->WriteString(form_data.origin.spec());
pickle->WriteString(form_data.action.spec());
pickle->WriteBool(form_data.user_submitted);
@@ -126,7 +120,6 @@ bool DeserializeFormData(PickleIterator* iter, FormData* form_data) {
switch (version) {
case 1: {
if (!iter->ReadString16(&form_data->name) ||
- !iter->ReadString16(&form_data->method) ||
!ReadGURL(iter, &form_data->origin) ||
!ReadGURL(iter, &form_data->action) ||
!iter->ReadBool(&form_data->user_submitted) ||
« no previous file with comments | « components/autofill/core/common/form_data.h ('k') | components/autofill/core/common/form_data_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698