Autofill: don't require POST method.

components/autofill/core/browser/form_structure.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_AUTOFILL_CORE_BROWSER_FORM_STRUCTURE_H_
 #define COMPONENTS_AUTOFILL_CORE_BROWSER_FORM_STRUCTURE_H_
 
 #include <set>
 #include <string>
 #include <vector>
 
 #include "base/callback.h"
 #include "base/gtest_prod_util.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/memory/scoped_vector.h"
 #include "base/strings/string16.h"
 #include "components/autofill/core/browser/autofill_field.h"
 #include "components/autofill/core/browser/autofill_type.h"
 #include "components/autofill/core/browser/field_types.h"
 #include "components/autofill/core/common/web_element_descriptor.h"
 #include "url/gurl.h"
 
-enum RequestMethod {
-  GET,
-  POST
-};
-
 enum UploadRequired {
   UPLOAD_NOT_REQUIRED,
   UPLOAD_REQUIRED,
   USE_UPLOAD_RATES
 };
 
 namespace base {
 class TimeTicks;
 }
 
@@ skipping 51 matching lines @@
   // fields' predicted types.
   static void GetFieldTypePredictions(
       const std::vector<FormStructure*>& form_structures,
       std::vector<FormDataPredictions>* forms);
 
   // The unique signature for this form, composed of the target url domain,
   // the form name, and the form field names in a 64-bit hash.
   std::string FormSignature() const;
 
   // Runs a quick heuristic to rule out forms that are obviously not
-  // auto-fillable, like google/yahoo/msn search, etc. The requirement that the
-  // form's method be POST is only applied if |require_method_post| is true.
-  bool IsAutofillable(bool require_method_post) const;
+  // auto-fillable, like google/yahoo/msn search, etc.
+  bool IsAutofillable() const;
 
   // Resets |autofill_count_| and counts the number of auto-fillable fields.
   // This is used when we receive server data for form fields.  At that time,
   // we may have more known fields than just the number of fields we matched
   // heuristically.
   void UpdateAutofillCount();
 
   // Returns true if this form matches the structural requirements for Autofill.
-  // The requirement that the form's method be POST is only applied if
-  // |require_method_post| is true.
-  bool ShouldBeParsed(bool require_method_post) const;
+  bool ShouldBeParsed() const;
 
   // Returns true if we should query the crowdsourcing server to determine this
   // form's field types.  If the form includes author-specified types, this will
   // return false.
   bool ShouldBeCrowdsourced() const;
 
   // Sets the field types to be those set for |cached_form|.
   void UpdateFromCache(const FormStructure& cached_form);
 
   // Logs quality metrics for |this|, which should be a user-submitted form.
@@ skipping 124 matching lines @@
 
   // The names of the form input elements, that are part of the form signature.
   // The string starts with "&" and the names are also separated by the "&"
   // character. E.g.: "&form_input1_name&form_input2_name&...&form_inputN_name"
   std::string form_signature_field_names_;
 
   // Whether the server expects us to always upload, never upload, or default
   // to the stored upload rates.
   UploadRequired upload_required_;
 
-  // GET or POST.
-  RequestMethod method_;
+  // The method attribute on the form (e.g. POST or GET).
+  base::string16 method_;

[Ilya Sherman, 2014/07/15 03:21:24]

Hmm, it doesn't look like this is used -- can this be removed?

[Evan Stade, 2014/07/15 19:01:57]

Done.

 
   // Whether the form includes any field types explicitly specified by the site
   // author, via the |autocompletetype| attribute.
   bool has_author_specified_types_;
 
   DISALLOW_COPY_AND_ASSIGN(FormStructure);
 };
 
 }  // namespace autofill
 
 #endif  // COMPONENTS_AUTOFILL_CORE_BROWSER_FORM_STRUCTURE_H_