Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(723)

Unified Diff: components/autofill/core/browser/form_structure.h

Issue 365783002: Autofill: don't require POST method. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: remove method_ member Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/core/browser/form_structure.h
diff --git a/components/autofill/core/browser/form_structure.h b/components/autofill/core/browser/form_structure.h
index 2192e12e4c72cd30074aad7ec35eb2ec33d8ceb7..7a9d915782a981f4f9f432369e1792f497dcdf75 100644
--- a/components/autofill/core/browser/form_structure.h
+++ b/components/autofill/core/browser/form_structure.h
@@ -20,11 +20,6 @@
#include "components/autofill/core/common/web_element_descriptor.h"
#include "url/gurl.h"
-enum RequestMethod {
- GET,
- POST
-};
-
enum UploadRequired {
UPLOAD_NOT_REQUIRED,
UPLOAD_REQUIRED,
@@ -96,9 +91,8 @@ class FormStructure {
std::string FormSignature() const;
// Runs a quick heuristic to rule out forms that are obviously not
- // auto-fillable, like google/yahoo/msn search, etc. The requirement that the
- // form's method be POST is only applied if |require_method_post| is true.
- bool IsAutofillable(bool require_method_post) const;
+ // auto-fillable, like google/yahoo/msn search, etc.
+ bool IsAutofillable() const;
// Resets |autofill_count_| and counts the number of auto-fillable fields.
// This is used when we receive server data for form fields. At that time,
@@ -107,9 +101,7 @@ class FormStructure {
void UpdateAutofillCount();
// Returns true if this form matches the structural requirements for Autofill.
- // The requirement that the form's method be POST is only applied if
- // |require_method_post| is true.
- bool ShouldBeParsed(bool require_method_post) const;
+ bool ShouldBeParsed() const;
// Returns true if we should query the crowdsourcing server to determine this
// form's field types. If the form includes author-specified types, this will
@@ -254,9 +246,6 @@ class FormStructure {
// to the stored upload rates.
UploadRequired upload_required_;
- // GET or POST.
- RequestMethod method_;
-
// Whether the form includes any field types explicitly specified by the site
// author, via the |autocompletetype| attribute.
bool has_author_specified_types_;
« no previous file with comments | « components/autofill/core/browser/autofill_test_utils.cc ('k') | components/autofill/core/browser/form_structure.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698