Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Unified Diff: components/autofill/core/common/save_password_progress_logger.cc

Issue 365783002: Autofill: don't require POST method. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: remove method_ member Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/core/common/save_password_progress_logger.cc
diff --git a/components/autofill/core/common/save_password_progress_logger.cc b/components/autofill/core/common/save_password_progress_logger.cc
index 9cc824e3a5d52e194d5fb16a46a56355a2c3d71e..a9ae6a83b73918ebbee7a4eca2c254f0e97792ef 100644
--- a/components/autofill/core/common/save_password_progress_logger.cc
+++ b/components/autofill/core/common/save_password_progress_logger.cc
@@ -39,14 +39,6 @@ std::string GetStringFromID(SavePasswordProgressLogger::StringID id) {
return "Decision: DROP the password";
case SavePasswordProgressLogger::STRING_DECISION_SAVE:
return "Decision: SAVE the password";
- case SavePasswordProgressLogger::STRING_METHOD:
- return "Form method";
- case SavePasswordProgressLogger::STRING_METHOD_GET:
- return "GET";
- case SavePasswordProgressLogger::STRING_METHOD_POST:
- return "POST";
- case SavePasswordProgressLogger::STRING_METHOD_EMPTY:
- return "(empty)";
case SavePasswordProgressLogger::STRING_OTHER:
return "(other)";
case SavePasswordProgressLogger::STRING_SCHEME_HTML:
@@ -223,21 +215,6 @@ std::string FormSchemeToString(PasswordForm::Scheme scheme) {
return GetStringFromID(result_id);
}
-std::string FormMethodToString(const std::string& method) {
- std::string method_processed;
- base::TrimWhitespaceASCII(
- StringToLowerASCII(method), base::TRIM_ALL, &method_processed);
- SavePasswordProgressLogger::StringID result_id =
- SavePasswordProgressLogger::STRING_OTHER;
- if (method_processed.empty())
- result_id = SavePasswordProgressLogger::STRING_METHOD_EMPTY;
- else if (method_processed == "get")
- result_id = SavePasswordProgressLogger::STRING_METHOD_GET;
- else if (method_processed == "post")
- result_id = SavePasswordProgressLogger::STRING_METHOD_POST;
- return GetStringFromID(result_id);
-}
-
} // namespace
SavePasswordProgressLogger::SavePasswordProgressLogger() {
@@ -281,11 +258,9 @@ void SavePasswordProgressLogger::LogPasswordForm(
void SavePasswordProgressLogger::LogHTMLForm(
SavePasswordProgressLogger::StringID label,
const std::string& name_or_id,
- const std::string& method,
const GURL& action) {
DictionaryValue log;
log.SetString(GetStringFromID(STRING_NAME_OR_ID), ScrubElementID(name_or_id));
- log.SetString(GetStringFromID(STRING_METHOD), FormMethodToString(method));
log.SetString(GetStringFromID(STRING_ACTION), ScrubURL(action));
LogValue(label, log);
}

Powered by Google App Engine
This is Rietveld 408576698