Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Unified Diff: components/autofill/core/browser/autofill_manager.cc

Issue 365783002: Autofill: don't require POST method. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: remove method_ member Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/core/browser/autofill_manager.cc
diff --git a/components/autofill/core/browser/autofill_manager.cc b/components/autofill/core/browser/autofill_manager.cc
index bc7030de5cd19e1677bba683577a06685fddb16f..cb4be9320a3c4b578a40564f83c59c8739784dd6 100644
--- a/components/autofill/core/browser/autofill_manager.cc
+++ b/components/autofill/core/browser/autofill_manager.cc
@@ -328,7 +328,7 @@ bool AutofillManager::OnFormSubmitted(const FormData& form,
return false;
submitted_form->UpdateFromCache(*cached_submitted_form);
- if (submitted_form->IsAutofillable(true))
+ if (submitted_form->IsAutofillable())
ImportFormData(*submitted_form);
// Only upload server statistics and UMA metrics if at least some local data
@@ -453,7 +453,7 @@ void AutofillManager::OnQueryFormFieldAutofill(int query_id,
driver_->RendererIsAvailable() &&
GetCachedFormAndField(form, field, &form_structure, &autofill_field) &&
// Don't send suggestions for forms that aren't auto-fillable.
- form_structure->IsAutofillable(false)) {
+ form_structure->IsAutofillable()) {
AutofillType type = autofill_field->Type();
bool is_filling_credit_card = (type.group() == CREDIT_CARD);
if (is_filling_credit_card) {
@@ -473,7 +473,7 @@ void AutofillManager::OnQueryFormFieldAutofill(int query_id,
// provide credit card suggestions for non-HTTPS pages. However, provide a
// warning to the user in these cases.
int warning = 0;
- if (!form_structure->IsAutofillable(true))
+ if (!form_structure->IsAutofillable())
warning = IDS_AUTOFILL_WARNING_FORM_DISABLED;
else if (is_filling_credit_card && !FormIsHTTPS(*form_structure))
warning = IDS_AUTOFILL_WARNING_INSECURE_CONNECTION;
@@ -978,7 +978,7 @@ bool AutofillManager::GetCachedFormAndField(const FormData& form,
// If we do not have this form in our cache but it is parseable, we'll add it
// in the call to |UpdateCachedForm()|.
if (!FindCachedForm(form, form_structure) &&
- !FormStructure(form).ShouldBeParsed(false)) {
+ !FormStructure(form).ShouldBeParsed()) {
return false;
}
@@ -1105,7 +1105,7 @@ void AutofillManager::ParseForms(const std::vector<FormData>& forms) {
for (std::vector<FormData>::const_iterator iter = forms.begin();
iter != forms.end(); ++iter) {
scoped_ptr<FormStructure> form_structure(new FormStructure(*iter));
- if (!form_structure->ShouldBeParsed(false))
+ if (!form_structure->ShouldBeParsed())
continue;
form_structure->DetermineHeuristicTypes(*metric_logger_);
@@ -1211,7 +1211,7 @@ bool AutofillManager::ShouldUploadForm(const FormStructure& form) {
return false;
// Disregard forms that we wouldn't ever autofill in the first place.
- if (!form.ShouldBeParsed(true))
+ if (!form.ShouldBeParsed())
return false;
return true;

Powered by Google App Engine
This is Rietveld 408576698