Split SetProperty(...attributes, strictmode) into AddProperty(...attributes) and SetProperty(...…

Split SetProperty(...attributes, strictmode) into DefineProperty(...attributes) and SetProperty(...strictmode)

BUG=
R=rossberg@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=22064

[Toon Verwaest, 2014-06-24 12:23:09]

PTAL

[rossberg, 2014-06-27 09:47:30]

https://codereview.chromium.org/351853005/diff/1/src/apinatives.js
File src/apinatives.js (right):

https://codereview.chromium.org/351853005/diff/1/src/apinatives.js#newcode42
src/apinatives.js:42: result = %ToFastProperties(result);
Is this actually needed in the then case?

https://codereview.chromium.org/351853005/diff/1/src/regexp.js
File src/regexp.js (right):

https://codereview.chromium.org/351853005/diff/1/src/regexp.js#newcode409
src/regexp.js:409: %DefineOrRedefineAccessorProperty($RegExp, 'input',
RegExpGetInput,
Can't these simply be %DefineAccessorProperty now?

https://codereview.chromium.org/351853005/diff/1/src/runtime.cc
File src/runtime.cc (right):

https://codereview.chromium.org/351853005/diff/1/src/runtime.cc#newcode5359
src/runtime.cc:5359: if (key->IsName()) {
Hm, it's unfortunate that one can bypass this check by passing a non-name that
is yet to be string-converted.

I suppose it's not feasible to actually narrow this runtime function to require
a name?

https://codereview.chromium.org/351853005/diff/1/src/runtime.h
File src/runtime.h (right):

https://codereview.chromium.org/351853005/diff/1/src/runtime.h#newcode209
src/runtime.h:209: F(DefineAccessorProperty, 5, 1) \
Nit: move this down to the other Define functions

https://codereview.chromium.org/351853005/diff/1/src/runtime.h#newcode227
src/runtime.h:227: F(DefineProperty, 4, 1) \
How about naming this DefineDataProperty, for symmetry?

https://codereview.chromium.org/351853005/diff/1/src/runtime.h#newcode819
src/runtime.h:819: MUST_USE_RESULT static MaybeHandle<Object>
ForceSetObjectProperty(
It might make sense to also rename this to DefineObjectProperty.

[Toon Verwaest, 2014-06-27 13:16:23]

PTAL again

https://codereview.chromium.org/351853005/diff/1/src/apinatives.js
File src/apinatives.js (right):

https://codereview.chromium.org/351853005/diff/1/src/apinatives.js#newcode42
src/apinatives.js:42: result = %ToFastProperties(result);
I guess it's unlikely to get normalized. Moved up.

On 2014/06/27 09:47:30, rossberg wrote:
> Is this actually needed in the then case?

https://codereview.chromium.org/351853005/diff/1/src/regexp.js
File src/regexp.js (right):

https://codereview.chromium.org/351853005/diff/1/src/regexp.js#newcode409
src/regexp.js:409: %DefineOrRedefineAccessorProperty($RegExp, 'input',
RegExpGetInput,
On 2014/06/27 09:47:30, rossberg wrote:
> Can't these simply be %DefineAccessorProperty now?

Done.

https://codereview.chromium.org/351853005/diff/1/src/runtime.h
File src/runtime.h (right):

https://codereview.chromium.org/351853005/diff/1/src/runtime.h#newcode209
src/runtime.h:209: F(DefineAccessorProperty, 5, 1) \
On 2014/06/27 09:47:30, rossberg wrote:
> Nit: move this down to the other Define functions

Done.

https://codereview.chromium.org/351853005/diff/1/src/runtime.h#newcode819
src/runtime.h:819: MUST_USE_RESULT static MaybeHandle<Object>
ForceSetObjectProperty(
On 2014/06/27 09:47:30, rossberg wrote:
> It might make sense to also rename this to DefineObjectProperty.

Done.

[rossberg, 2014-06-27 13:24:41]

lgtm

[Toon Verwaest, 2014-06-27 13:49:29]

Committed patchset #4 manually as r22064 (presubmit successful).