src/ia32/full-codegen-ia32.cc - Issue 351853005: Split SetProperty(...attributes, strictmode) into AddProperty(...attributes) and SetProperty(...…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ia32/full-codegen-ia32.cc

Issue 351853005: Split SetProperty(...attributes, strictmode) into AddProperty(...attributes) and SetProperty(...… (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/ia32/full-codegen-ia32.cc

diff --git a/src/ia32/full-codegen-ia32.cc b/src/ia32/full-codegen-ia32.cc

index 1007a87a25d48cf4227b5a6b64748f8e3b82dd88..cf99052d325900c43f99144c2c66553caf9c5324 100644

--- a/src/ia32/full-codegen-ia32.cc

+++ b/src/ia32/full-codegen-ia32.cc

@@ -1649,7 +1649,7 @@ void FullCodeGenerator::VisitObjectLiteral(ObjectLiteral* expr) {

VisitForStackValue(value);

if (property->emit_store()) {

__ push(Immediate(Smi::FromInt(NONE))); // PropertyAttributes

- __ CallRuntime(Runtime::kSetProperty, 4);

+ __ CallRuntime(Runtime::kAddProperty, 4);

} else {

__ Drop(3);

}

@@ -1682,7 +1682,7 @@ void FullCodeGenerator::VisitObjectLiteral(ObjectLiteral* expr) {

EmitAccessor(it->second->getter);

EmitAccessor(it->second->setter);

__ push(Immediate(Smi::FromInt(NONE)));

- __ CallRuntime(Runtime::kDefineOrRedefineAccessorProperty, 5);

+ __ CallRuntime(Runtime::kDefineAccessorPropertyUnchecked, 5);

}

if (expr->has_function()) {

« no previous file with comments | « src/i18n.js ('k') | src/ia32/ic-ia32.cc » ('j') | no next file with comments »