src/ia32/ic-ia32.cc - Issue 351853005: Split SetProperty(...attributes, strictmode) into AddProperty(...attributes) and SetProperty(...…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ia32/ic-ia32.cc

Issue 351853005: Split SetProperty(...attributes, strictmode) into AddProperty(...attributes) and SetProperty(...… (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/ia32/ic-ia32.cc

diff --git a/src/ia32/ic-ia32.cc b/src/ia32/ic-ia32.cc

index b0e4ca0c60c2675899383b5a0fd95fe16546115d..fec6403a5596e1debcad2925d3ca43e9d90ef140 100644

--- a/src/ia32/ic-ia32.cc

+++ b/src/ia32/ic-ia32.cc

@@ -1122,12 +1122,11 @@ void StoreIC::GenerateRuntimeSetProperty(MacroAssembler* masm,

__ push(edx);

__ push(ecx);

__ push(eax);

- __ push(Immediate(Smi::FromInt(NONE))); // PropertyAttributes

__ push(Immediate(Smi::FromInt(strict_mode)));

__ push(ebx); // return address

// Do tail-call to runtime routine.

- __ TailCallRuntime(Runtime::kSetProperty, 5, 1);

+ __ TailCallRuntime(Runtime::kSetProperty, 4, 1);

}

@@ -1144,12 +1143,11 @@ void KeyedStoreIC::GenerateRuntimeSetProperty(MacroAssembler* masm,