Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Side by Side Diff: src/arm64/full-codegen-arm64.cc

Issue 351853005: Split SetProperty(...attributes, strictmode) into AddProperty(...attributes) and SetProperty(...… (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/arm/ic-arm.cc ('k') | src/array.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_ARM64 7 #if V8_TARGET_ARCH_ARM64
8 8
9 #include "src/code-stubs.h" 9 #include "src/code-stubs.h"
10 #include "src/codegen.h" 10 #include "src/codegen.h"
(...skipping 1682 matching lines...) Expand 10 before | Expand all | Expand 10 after
1693 break; 1693 break;
1694 } 1694 }
1695 if (property->emit_store()) { 1695 if (property->emit_store()) {
1696 // Duplicate receiver on stack. 1696 // Duplicate receiver on stack.
1697 __ Peek(x0, 0); 1697 __ Peek(x0, 0);
1698 __ Push(x0); 1698 __ Push(x0);
1699 VisitForStackValue(key); 1699 VisitForStackValue(key);
1700 VisitForStackValue(value); 1700 VisitForStackValue(value);
1701 __ Mov(x0, Smi::FromInt(NONE)); // PropertyAttributes 1701 __ Mov(x0, Smi::FromInt(NONE)); // PropertyAttributes
1702 __ Push(x0); 1702 __ Push(x0);
1703 __ CallRuntime(Runtime::kSetProperty, 4); 1703 __ CallRuntime(Runtime::kAddProperty, 4);
1704 } else { 1704 } else {
1705 VisitForEffect(key); 1705 VisitForEffect(key);
1706 VisitForEffect(value); 1706 VisitForEffect(value);
1707 } 1707 }
1708 break; 1708 break;
1709 case ObjectLiteral::Property::PROTOTYPE: 1709 case ObjectLiteral::Property::PROTOTYPE:
1710 if (property->emit_store()) { 1710 if (property->emit_store()) {
1711 // Duplicate receiver on stack. 1711 // Duplicate receiver on stack.
1712 __ Peek(x0, 0); 1712 __ Peek(x0, 0);
1713 __ Push(x0); 1713 __ Push(x0);
(...skipping 17 matching lines...) Expand all
1731 for (AccessorTable::Iterator it = accessor_table.begin(); 1731 for (AccessorTable::Iterator it = accessor_table.begin();
1732 it != accessor_table.end(); 1732 it != accessor_table.end();
1733 ++it) { 1733 ++it) {
1734 __ Peek(x10, 0); // Duplicate receiver. 1734 __ Peek(x10, 0); // Duplicate receiver.
1735 __ Push(x10); 1735 __ Push(x10);
1736 VisitForStackValue(it->first); 1736 VisitForStackValue(it->first);
1737 EmitAccessor(it->second->getter); 1737 EmitAccessor(it->second->getter);
1738 EmitAccessor(it->second->setter); 1738 EmitAccessor(it->second->setter);
1739 __ Mov(x10, Smi::FromInt(NONE)); 1739 __ Mov(x10, Smi::FromInt(NONE));
1740 __ Push(x10); 1740 __ Push(x10);
1741 __ CallRuntime(Runtime::kDefineOrRedefineAccessorProperty, 5); 1741 __ CallRuntime(Runtime::kDefineAccessorPropertyUnchecked, 5);
1742 } 1742 }
1743 1743
1744 if (expr->has_function()) { 1744 if (expr->has_function()) {
1745 ASSERT(result_saved); 1745 ASSERT(result_saved);
1746 __ Peek(x0, 0); 1746 __ Peek(x0, 0);
1747 __ Push(x0); 1747 __ Push(x0);
1748 __ CallRuntime(Runtime::kToFastProperties, 1); 1748 __ CallRuntime(Runtime::kToFastProperties, 1);
1749 } 1749 }
1750 1750
1751 if (result_saved) { 1751 if (result_saved) {
(...skipping 3134 matching lines...) Expand 10 before | Expand all | Expand 10 after
4886 return previous_; 4886 return previous_;
4887 } 4887 }
4888 4888
4889 4889
4890 #undef __ 4890 #undef __
4891 4891
4892 4892
4893 } } // namespace v8::internal 4893 } } // namespace v8::internal
4894 4894
4895 #endif // V8_TARGET_ARCH_ARM64 4895 #endif // V8_TARGET_ARCH_ARM64
OLDNEW
« no previous file with comments | « src/arm/ic-arm.cc ('k') | src/array.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698