src/object-observe.js - Issue 351853005: Split SetProperty(...attributes, strictmode) into AddProperty(...attributes) and SetProperty(...…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/object-observe.js

Issue 351853005: Split SetProperty(...attributes, strictmode) into AddProperty(...attributes) and SetProperty(...… (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/object-observe.js

diff --git a/src/object-observe.js b/src/object-observe.js

index 2dfc7522f77ab6db88baf125a0be4ab3707d8092..a6277575086c96d4b027642d09331e66574ac115 100644

--- a/src/object-observe.js

+++ b/src/object-observe.js

@@ -438,8 +438,7 @@ function ObjectInfoEnqueueExternalChangeRecord(objectInfo, changeRecord, type) {

for (var prop in changeRecord) {

if (prop === 'object' || (hasType && prop === 'type')) continue;

- %DefineOrRedefineDataProperty(newRecord, prop, changeRecord[prop],

- READ_ONLY + DONT_DELETE);

+ %AddProperty(newRecord, prop, changeRecord[prop], READ_ONLY + DONT_DELETE);

}

ObjectFreezeJS(newRecord);

« no previous file with comments | « src/mips/full-codegen-mips.cc ('k') | src/promise.js » ('j') | no next file with comments »