Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Side by Side Diff: src/ia32/ic-ia32.cc

Issue 351853005: Split SetProperty(...attributes, strictmode) into AddProperty(...attributes) and SetProperty(...… (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/ia32/full-codegen-ia32.cc ('k') | src/ic.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_IA32 7 #if V8_TARGET_ARCH_IA32
8 8
9 #include "src/codegen.h" 9 #include "src/codegen.h"
10 #include "src/ic-inl.h" 10 #include "src/ic-inl.h"
(...skipping 1104 matching lines...) Expand 10 before | Expand all | Expand 10 after
1115 // ----------- S t a t e ------------- 1115 // ----------- S t a t e -------------
1116 // -- eax : value 1116 // -- eax : value
1117 // -- ecx : name 1117 // -- ecx : name
1118 // -- edx : receiver 1118 // -- edx : receiver
1119 // -- esp[0] : return address 1119 // -- esp[0] : return address
1120 // ----------------------------------- 1120 // -----------------------------------
1121 __ pop(ebx); 1121 __ pop(ebx);
1122 __ push(edx); 1122 __ push(edx);
1123 __ push(ecx); 1123 __ push(ecx);
1124 __ push(eax); 1124 __ push(eax);
1125 __ push(Immediate(Smi::FromInt(NONE))); // PropertyAttributes
1126 __ push(Immediate(Smi::FromInt(strict_mode))); 1125 __ push(Immediate(Smi::FromInt(strict_mode)));
1127 __ push(ebx); // return address 1126 __ push(ebx); // return address
1128 1127
1129 // Do tail-call to runtime routine. 1128 // Do tail-call to runtime routine.
1130 __ TailCallRuntime(Runtime::kSetProperty, 5, 1); 1129 __ TailCallRuntime(Runtime::kSetProperty, 4, 1);
1131 } 1130 }
1132 1131
1133 1132
1134 void KeyedStoreIC::GenerateRuntimeSetProperty(MacroAssembler* masm, 1133 void KeyedStoreIC::GenerateRuntimeSetProperty(MacroAssembler* masm,
1135 StrictMode strict_mode) { 1134 StrictMode strict_mode) {
1136 // ----------- S t a t e ------------- 1135 // ----------- S t a t e -------------
1137 // -- eax : value 1136 // -- eax : value
1138 // -- ecx : key 1137 // -- ecx : key
1139 // -- edx : receiver 1138 // -- edx : receiver
1140 // -- esp[0] : return address 1139 // -- esp[0] : return address
1141 // ----------------------------------- 1140 // -----------------------------------
1142 1141
1143 __ pop(ebx); 1142 __ pop(ebx);
1144 __ push(edx); 1143 __ push(edx);
1145 __ push(ecx); 1144 __ push(ecx);
1146 __ push(eax); 1145 __ push(eax);
1147 __ push(Immediate(Smi::FromInt(NONE))); // PropertyAttributes
1148 __ push(Immediate(Smi::FromInt(strict_mode))); // Strict mode. 1146 __ push(Immediate(Smi::FromInt(strict_mode))); // Strict mode.
1149 __ push(ebx); // return address 1147 __ push(ebx); // return address
1150 1148
1151 // Do tail-call to runtime routine. 1149 // Do tail-call to runtime routine.
1152 __ TailCallRuntime(Runtime::kSetProperty, 5, 1); 1150 __ TailCallRuntime(Runtime::kSetProperty, 4, 1);
1153 } 1151 }
1154 1152
1155 1153
1156 void KeyedStoreIC::GenerateMiss(MacroAssembler* masm) { 1154 void KeyedStoreIC::GenerateMiss(MacroAssembler* masm) {
1157 // ----------- S t a t e ------------- 1155 // ----------- S t a t e -------------
1158 // -- eax : value 1156 // -- eax : value
1159 // -- ecx : key 1157 // -- ecx : key
1160 // -- edx : receiver 1158 // -- edx : receiver
1161 // -- esp[0] : return address 1159 // -- esp[0] : return address
1162 // ----------------------------------- 1160 // -----------------------------------
(...skipping 118 matching lines...) Expand 10 before | Expand all | Expand 10 after
1281 Condition cc = (check == ENABLE_INLINED_SMI_CHECK) 1279 Condition cc = (check == ENABLE_INLINED_SMI_CHECK)
1282 ? (*jmp_address == Assembler::kJncShortOpcode ? not_zero : zero) 1280 ? (*jmp_address == Assembler::kJncShortOpcode ? not_zero : zero)
1283 : (*jmp_address == Assembler::kJnzShortOpcode ? not_carry : carry); 1281 : (*jmp_address == Assembler::kJnzShortOpcode ? not_carry : carry);
1284 *jmp_address = static_cast<byte>(Assembler::kJccShortPrefix | cc); 1282 *jmp_address = static_cast<byte>(Assembler::kJccShortPrefix | cc);
1285 } 1283 }
1286 1284
1287 1285
1288 } } // namespace v8::internal 1286 } } // namespace v8::internal
1289 1287
1290 #endif // V8_TARGET_ARCH_IA32 1288 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/ia32/full-codegen-ia32.cc ('k') | src/ic.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698