Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Side by Side Diff: src/mips/full-codegen-mips.cc

Issue 351853005: Split SetProperty(...attributes, strictmode) into AddProperty(...attributes) and SetProperty(...… (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/messages.js ('k') | src/object-observe.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_MIPS 7 #if V8_TARGET_ARCH_MIPS
8 8
9 // Note on Mips implementation: 9 // Note on Mips implementation:
10 // 10 //
(...skipping 1691 matching lines...) Expand 10 before | Expand all | Expand 10 after
1702 break; 1702 break;
1703 } 1703 }
1704 // Duplicate receiver on stack. 1704 // Duplicate receiver on stack.
1705 __ lw(a0, MemOperand(sp)); 1705 __ lw(a0, MemOperand(sp));
1706 __ push(a0); 1706 __ push(a0);
1707 VisitForStackValue(key); 1707 VisitForStackValue(key);
1708 VisitForStackValue(value); 1708 VisitForStackValue(value);
1709 if (property->emit_store()) { 1709 if (property->emit_store()) {
1710 __ li(a0, Operand(Smi::FromInt(NONE))); // PropertyAttributes. 1710 __ li(a0, Operand(Smi::FromInt(NONE))); // PropertyAttributes.
1711 __ push(a0); 1711 __ push(a0);
1712 __ CallRuntime(Runtime::kSetProperty, 4); 1712 __ CallRuntime(Runtime::kAddProperty, 4);
1713 } else { 1713 } else {
1714 __ Drop(3); 1714 __ Drop(3);
1715 } 1715 }
1716 break; 1716 break;
1717 case ObjectLiteral::Property::PROTOTYPE: 1717 case ObjectLiteral::Property::PROTOTYPE:
1718 // Duplicate receiver on stack. 1718 // Duplicate receiver on stack.
1719 __ lw(a0, MemOperand(sp)); 1719 __ lw(a0, MemOperand(sp));
1720 __ push(a0); 1720 __ push(a0);
1721 VisitForStackValue(value); 1721 VisitForStackValue(value);
1722 if (property->emit_store()) { 1722 if (property->emit_store()) {
(...skipping 16 matching lines...) Expand all
1739 for (AccessorTable::Iterator it = accessor_table.begin(); 1739 for (AccessorTable::Iterator it = accessor_table.begin();
1740 it != accessor_table.end(); 1740 it != accessor_table.end();
1741 ++it) { 1741 ++it) {
1742 __ lw(a0, MemOperand(sp)); // Duplicate receiver. 1742 __ lw(a0, MemOperand(sp)); // Duplicate receiver.
1743 __ push(a0); 1743 __ push(a0);
1744 VisitForStackValue(it->first); 1744 VisitForStackValue(it->first);
1745 EmitAccessor(it->second->getter); 1745 EmitAccessor(it->second->getter);
1746 EmitAccessor(it->second->setter); 1746 EmitAccessor(it->second->setter);
1747 __ li(a0, Operand(Smi::FromInt(NONE))); 1747 __ li(a0, Operand(Smi::FromInt(NONE)));
1748 __ push(a0); 1748 __ push(a0);
1749 __ CallRuntime(Runtime::kDefineOrRedefineAccessorProperty, 5); 1749 __ CallRuntime(Runtime::kDefineAccessorPropertyUnchecked, 5);
1750 } 1750 }
1751 1751
1752 if (expr->has_function()) { 1752 if (expr->has_function()) {
1753 ASSERT(result_saved); 1753 ASSERT(result_saved);
1754 __ lw(a0, MemOperand(sp)); 1754 __ lw(a0, MemOperand(sp));
1755 __ push(a0); 1755 __ push(a0);
1756 __ CallRuntime(Runtime::kToFastProperties, 1); 1756 __ CallRuntime(Runtime::kToFastProperties, 1);
1757 } 1757 }
1758 1758
1759 if (result_saved) { 1759 if (result_saved) {
(...skipping 3083 matching lines...) Expand 10 before | Expand all | Expand 10 after
4843 Assembler::target_address_at(pc_immediate_load_address)) == 4843 Assembler::target_address_at(pc_immediate_load_address)) ==
4844 reinterpret_cast<uint32_t>( 4844 reinterpret_cast<uint32_t>(
4845 isolate->builtins()->OsrAfterStackCheck()->entry())); 4845 isolate->builtins()->OsrAfterStackCheck()->entry()));
4846 return OSR_AFTER_STACK_CHECK; 4846 return OSR_AFTER_STACK_CHECK;
4847 } 4847 }
4848 4848
4849 4849
4850 } } // namespace v8::internal 4850 } } // namespace v8::internal
4851 4851
4852 #endif // V8_TARGET_ARCH_MIPS 4852 #endif // V8_TARGET_ARCH_MIPS
OLDNEW
« no previous file with comments | « src/messages.js ('k') | src/object-observe.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698