Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 333933003: [Android] Switch to DeviceUtils version of RunShellCommand. (Closed)

Created:
6 years, 6 months ago by jbudorick
Modified:
6 years, 6 months ago
CC:
chromium-reviews, bulach+watch_chromium.org, yfriedman+watch_chromium.org, timurrrr+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, telemetry+watch_chromium.org, glider+watch_chromium.org, bruening+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[Android] Switch to DeviceUtils version of RunShellCommand. BUG=267773 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277508

Patch Set 1 #

Patch Set 2 : #

Total comments: 4

Patch Set 3 : #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+176 lines, -125 lines) Patch
M build/android/enable_asserts.py View 1 chunk +2 lines, -2 lines 0 comments Download
M build/android/gyp/util/build_device.py View 3 chunks +3 lines, -3 lines 0 comments Download
M build/android/host_heartbeat.py View 1 chunk +1 line, -1 line 0 comments Download
M build/android/provision_devices.py View 1 2 3 4 chunks +13 lines, -12 lines 0 comments Download
M build/android/pylib/android_commands.py View 1 2 3 1 chunk +0 lines, -2 lines 0 comments Download
M build/android/pylib/content_settings.py View 2 chunks +13 lines, -10 lines 0 comments Download
M build/android/pylib/device/device_utils.py View 1 2 3 chunks +67 lines, -1 line 0 comments Download
M build/android/pylib/flag_changer.py View 1 chunk +1 line, -5 lines 0 comments Download
M build/android/pylib/gtest/test_package_apk.py View 2 chunks +3 lines, -3 lines 0 comments Download
M build/android/pylib/gtest/test_package_exe.py View 1 chunk +1 line, -1 line 0 comments Download
M build/android/pylib/instrumentation/test_runner.py View 2 chunks +3 lines, -3 lines 0 comments Download
M build/android/pylib/linker/test_case.py View 1 chunk +1 line, -1 line 0 comments Download
M build/android/pylib/monkey/test_runner.py View 1 chunk +1 line, -2 lines 0 comments Download
M build/android/pylib/perf/cache_control.py View 1 chunk +1 line, -1 line 0 comments Download
M build/android/pylib/perf/perf_control.py View 2 chunks +3 lines, -4 lines 0 comments Download
M build/android/pylib/perf/perf_control_unittest.py View 1 chunk +3 lines, -3 lines 0 comments Download
M build/android/pylib/perf/surface_stats_collector.py View 3 chunks +4 lines, -6 lines 0 comments Download
M build/android/pylib/perf/thermal_throttle.py View 2 chunks +2 lines, -3 lines 0 comments Download
M build/android/pylib/ports.py View 1 chunk +1 line, -2 lines 0 comments Download
M build/android/pylib/screenshot.py View 2 chunks +2 lines, -2 lines 0 comments Download
M build/android/pylib/utils/emulator.py View 1 chunk +1 line, -0 lines 0 comments Download
M build/android/pylib/valgrind_tools.py View 3 chunks +7 lines, -7 lines 0 comments Download
M build/android/tombstones.py View 3 chunks +4 lines, -5 lines 0 comments Download
M tools/android/adb_profile_chrome/perf_controller.py View 1 2 3 2 chunks +2 lines, -3 lines 0 comments Download
M tools/android/adb_profile_chrome/systrace_controller.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/memory_inspector/memory_inspector/backends/android/android_backend.py View 4 chunks +6 lines, -9 lines 0 comments Download
M tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py View 1 2 6 chunks +14 lines, -11 lines 0 comments Download
M tools/telemetry/telemetry/core/forwarders/android_forwarder.py View 4 chunks +5 lines, -5 lines 0 comments Download
M tools/telemetry/telemetry/core/platform/android_platform_backend.py View 3 chunks +3 lines, -6 lines 0 comments Download
M tools/telemetry/telemetry/core/platform/power_monitor/android_ds2784_power_monitor.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/core/platform/power_monitor/android_dumpsys_power_monitor.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/core/platform/profiler/android_prebuilt_profiler_helper.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/core/platform/profiler/android_profiling_helper.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/core/platform/profiler/netlog_profiler.py View 1 chunk +1 line, -2 lines 0 comments Download
M tools/telemetry/telemetry/core/platform/profiler/perf_profiler.py View 1 chunk +1 line, -2 lines 0 comments Download
M tools/telemetry/telemetry/core/platform/profiler/v8_profiler.py View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
jbudorick
6 years, 6 months ago (2014-06-13 21:49:22 UTC) #1
tonyg
Are there any expected differences between the old and new method? https://codereview.chromium.org/333933003/diff/20001/tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py File tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py (right): ...
6 years, 6 months ago (2014-06-13 23:07:04 UTC) #2
frankf
device_util.py lgtm w/ nits https://codereview.chromium.org/333933003/diff/20001/build/android/pylib/device/device_utils.py File build/android/pylib/device/device_utils.py (right): https://codereview.chromium.org/333933003/diff/20001/build/android/pylib/device/device_utils.py#newcode249 build/android/pylib/device/device_utils.py:249: """ Run an ADB shell ...
6 years, 6 months ago (2014-06-13 23:16:10 UTC) #3
craigdh
lgtm.
6 years, 6 months ago (2014-06-13 23:17:04 UTC) #4
jbudorick
On 2014/06/13 23:07:04, tonyg wrote: > Are there any expected differences between the old and ...
6 years, 6 months ago (2014-06-13 23:19:15 UTC) #5
jbudorick
On 2014/06/13 23:16:10, frankf wrote: > device_util.py lgtm w/ nits > > https://codereview.chromium.org/333933003/diff/20001/build/android/pylib/device/device_utils.py > File ...
6 years, 6 months ago (2014-06-13 23:20:43 UTC) #6
tonyg
> https://codereview.chromium.org/333933003/diff/20001/tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py#newcode96 > tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py:96: > 'dumpsys package %s' % self.package, root=True) > No root needed ...
6 years, 6 months ago (2014-06-13 23:23:52 UTC) #7
jbudorick
The CQ bit was checked by jbudorick@chromium.org
6 years, 6 months ago (2014-06-16 16:02:44 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jbudorick@chromium.org/333933003/60001
6 years, 6 months ago (2014-06-16 16:03:58 UTC) #9
commit-bot: I haz the power
6 years, 6 months ago (2014-06-16 18:59:34 UTC) #10
Message was sent while issue was closed. 
Change committed as 277508

Powered by Google App Engine
This is Rietveld 408576698