tools/telemetry/telemetry/core/platform/profiler/android_profiling_helper.py - Issue 333933003: [Android] Switch to DeviceUtils version of RunShellCommand.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/core/platform/profiler/android_profiling_helper.py

Issue 333933003: [Android] Switch to DeviceUtils version of RunShellCommand. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/telemetry/telemetry/core/platform/profiler/android_prebuilt_profiler_helper.py ('k') | tools/telemetry/telemetry/core/platform/profiler/netlog_profiler.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/core/platform/profiler/android_profiling_helper.py

diff --git a/tools/telemetry/telemetry/core/platform/profiler/android_profiling_helper.py b/tools/telemetry/telemetry/core/platform/profiler/android_profiling_helper.py

index f2e21440385eb434bb870307841356d9be3dcbbc..8b640939ca615517f0cf5c3c671c0207a4f631d6 100644

--- a/tools/telemetry/telemetry/core/platform/profiler/android_profiling_helper.py

+++ b/tools/telemetry/telemetry/core/platform/profiler/android_profiling_helper.py

@@ -36,7 +36,7 @@ def _ElfSectionMd5Sum(elf_file, section):

def _FindMatchingUnstrippedLibraryOnHost(device, lib):

lib_base = os.path.basename(lib)

- device_md5 = device.old_interface.RunShellCommandWithSU('md5 "%s"' % lib)[0]

+ device_md5 = device.RunShellCommand('md5 "%s"' % lib, root=True)[0]

device_md5 = device_md5.split(' ', 1)[0]

def FindMatchingStrippedLibrary(out_path):