tools/telemetry/telemetry/core/platform/profiler/v8_profiler.py - Issue 333933003: [Android] Switch to DeviceUtils version of RunShellCommand.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/core/platform/profiler/v8_profiler.py

Issue 333933003: [Android] Switch to DeviceUtils version of RunShellCommand. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/telemetry/telemetry/core/platform/profiler/v8_profiler.py

diff --git a/tools/telemetry/telemetry/core/platform/profiler/v8_profiler.py b/tools/telemetry/telemetry/core/platform/profiler/v8_profiler.py

index a804cfe24f78e388bf1ca72fb45ec6e6a8a51e44..e29bb0781ea12078c93e876434c69b843ab8f5a9 100644

--- a/tools/telemetry/telemetry/core/platform/profiler/v8_profiler.py

+++ b/tools/telemetry/telemetry/core/platform/profiler/v8_profiler.py

@@ -40,8 +40,7 @@ class V8Profiler(profiler.Profiler):

self._browser_backend.adb.device().old_interface.Adb().Pull(

output_file, host_output_file)

# Clean the device

- self._browser_backend.adb.device().old_interface.RunShellCommand(

- 'rm %s' % output_file)

+ self._browser_backend.adb.device().RunShellCommand('rm %s' % output_file)

output_file = host_output_file

print 'V8 profile saved as %s' % output_file

print 'To view, open in ' \

« no previous file with comments | « tools/telemetry/telemetry/core/platform/profiler/perf_profiler.py ('k') | no next file » | no next file with comments »