tools/android/adb_profile_chrome/systrace_controller.py - Issue 333933003: [Android] Switch to DeviceUtils version of RunShellCommand.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/android/adb_profile_chrome/systrace_controller.py

Issue 333933003: [Android] Switch to DeviceUtils version of RunShellCommand. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/android/adb_profile_chrome/perf_controller.py ('k') | tools/memory_inspector/memory_inspector/backends/android/android_backend.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/android/adb_profile_chrome/systrace_controller.py

diff --git a/tools/android/adb_profile_chrome/systrace_controller.py b/tools/android/adb_profile_chrome/systrace_controller.py

index 369bc88ea31fa6ba402233cb4d3d6ebd691dc2de..3ec4cc7d754b3b2df9c060e2e2e8f4e93d9d649b 100644

--- a/tools/android/adb_profile_chrome/systrace_controller.py

+++ b/tools/android/adb_profile_chrome/systrace_controller.py

@@ -37,7 +37,7 @@ class SystraceController(controllers.BaseController):

@staticmethod

def GetCategories(device):

- return device.old_interface.RunShellCommand('atrace --list_categories')

+ return device.RunShellCommand('atrace --list_categories')

def StartTracing(self, _):

self._thread = threading.Thread(target=self._CollectData)