tools/android/adb_profile_chrome/perf_controller.py - Issue 333933003: [Android] Switch to DeviceUtils version of RunShellCommand.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/android/adb_profile_chrome/perf_controller.py

Issue 333933003: [Android] Switch to DeviceUtils version of RunShellCommand. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/android/adb_profile_chrome/perf_controller.py

diff --git a/tools/android/adb_profile_chrome/perf_controller.py b/tools/android/adb_profile_chrome/perf_controller.py

index 064300d38aeead490bae3c74dc9ad74bf31ef52d..523fb855ff1156999b4ca1b129145ea9a5d60305 100644

--- a/tools/android/adb_profile_chrome/perf_controller.py

+++ b/tools/android/adb_profile_chrome/perf_controller.py

@@ -65,8 +65,7 @@ class _PerfProfiler(object):

def SignalAndWait(self):

perf_pids = self._device.old_interface.ExtractPid('perf')

- self._device.old_interface.RunShellCommand(

- 'kill -SIGINT ' + ' '.join(perf_pids))

+ self._device.RunShellCommand('kill -SIGINT ' + ' '.join(perf_pids))

self._perf_process.wait()

self._perf_control.ForceAllCpusOnline(False)

@@ -117,7 +116,7 @@ class PerfProfilerController(controllers.BaseController):

@classmethod

def GetCategories(cls, device):

perf_binary = cls._PrepareDevice(device)

- return device.old_interface.RunShellCommand('%s list' % perf_binary)

+ return device.RunShellCommand('%s list' % perf_binary)

def StartTracing(self, _):

self._perf_instance = _PerfProfiler(self._device,

« no previous file with comments | « build/android/tombstones.py ('k') | tools/android/adb_profile_chrome/systrace_controller.py » ('j') | no next file with comments »