tools/telemetry/telemetry/core/platform/power_monitor/android_ds2784_power_monitor.py - Issue 333933003: [Android] Switch to DeviceUtils version of RunShellCommand.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/core/platform/power_monitor/android_ds2784_power_monitor.py

Issue 333933003: [Android] Switch to DeviceUtils version of RunShellCommand. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/telemetry/telemetry/core/platform/android_platform_backend.py ('k') | tools/telemetry/telemetry/core/platform/power_monitor/android_dumpsys_power_monitor.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/core/platform/power_monitor/android_ds2784_power_monitor.py

diff --git a/tools/telemetry/telemetry/core/platform/power_monitor/android_ds2784_power_monitor.py b/tools/telemetry/telemetry/core/platform/power_monitor/android_ds2784_power_monitor.py

index 8b66e89d4dc58900e64bd2eedd846a08a6522999..8d4ae26f778212ef4cb62530a2e489c7bde31eee 100644

--- a/tools/telemetry/telemetry/core/platform/power_monitor/android_ds2784_power_monitor.py

+++ b/tools/telemetry/telemetry/core/platform/power_monitor/android_ds2784_power_monitor.py

@@ -45,7 +45,7 @@ class DS2784PowerMonitor(power_monitor.PowerMonitor):

android_prebuilt_profiler_helper.InstallOnDevice(

self._device, 'file_poller')

self._powermonitor_process_port = int(

- self._device.old_interface.RunShellCommand(

+ self._device.RunShellCommand(

'%s %d %s %s %s' % (self._file_poller_binary, SAMPLE_RATE_HZ,

CHARGE_COUNTER, CURRENT, VOLTAGE))[0])

@@ -53,7 +53,7 @@ class DS2784PowerMonitor(power_monitor.PowerMonitor):

assert self._powermonitor_process_port, (

'StartMonitoringPower() not called.')

try:

- result = '\n'.join(self._device.old_interface.RunShellCommand(

+ result = '\n'.join(self._device.RunShellCommand(

'%s %d' % (self._file_poller_binary,

self._powermonitor_process_port)))

assert result, 'PowerMonitor produced no output'