tools/telemetry/telemetry/core/platform/power_monitor/android_dumpsys_power_monitor.py - Issue 333933003: [Android] Switch to DeviceUtils version of RunShellCommand.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/core/platform/power_monitor/android_dumpsys_power_monitor.py

Issue 333933003: [Android] Switch to DeviceUtils version of RunShellCommand. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/telemetry/telemetry/core/platform/power_monitor/android_ds2784_power_monitor.py ('k') | tools/telemetry/telemetry/core/platform/profiler/android_prebuilt_profiler_helper.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/core/platform/power_monitor/android_dumpsys_power_monitor.py

diff --git a/tools/telemetry/telemetry/core/platform/power_monitor/android_dumpsys_power_monitor.py b/tools/telemetry/telemetry/core/platform/power_monitor/android_dumpsys_power_monitor.py

index 15e80f035689f2e80b3a71b90f2d1a2db3f1256f..9432d7079a9e96acfe9b4b0ed88084df2b2e4fa8 100644

--- a/tools/telemetry/telemetry/core/platform/power_monitor/android_dumpsys_power_monitor.py

+++ b/tools/telemetry/telemetry/core/platform/power_monitor/android_dumpsys_power_monitor.py

@@ -46,7 +46,7 @@ class DumpsysPowerMonitor(power_monitor.PowerMonitor):

package = self._browser._browser_backend.package

# By default, 'dumpsys batterystats' measures power consumption during the

# last unplugged period.

- result = self._device.old_interface.RunShellCommand(

+ result = self._device.RunShellCommand(

'dumpsys batterystats -c %s' % package)

assert result, 'Dumpsys produced no output'

return DumpsysPowerMonitor.ParseSamplingOutput(package, result)