Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(657)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 311783002: Revert r274404 and r274409: (Closed)

Created:
6 years, 6 months ago by tzik
Modified:
6 years, 6 months ago
Reviewers:
sadrul
CC:
chromium-reviews, ben+aura_chromium.org, Ian Vollick, jam, sadrul, sievers+watch_chromium.org, jbauman+watch_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org, kalyank, danakj+watch_chromium.org, cc-bugs_chromium.org, ben+ash_chromium.org
Visibility:
Public.

Description

Revert r274404 and r274409: "compositor: Tick the UI animations from cc, instead of from timer callbacks." "asan: Fix asan leak from r274404." These CLs seem to break ash_unittests on win8 aura bot: http://build.chromium.org/p/chromium.win/buildstatus?builder=Win8%20Aura&number=19390 BUG=371071 TBR=sadrul@chromium.org NOTREECHECKS=true NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274423

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+191 lines, -560 lines) Patch
M ash/desktop_background/desktop_background_controller_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/shelf/shelf_layout_manager_unittest.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M ash/wm/window_animations_unittest.cc View 4 chunks +14 lines, -10 lines 0 comments Download
M ash/wm/workspace_controller_unittest.cc View 2 chunks +0 lines, -7 lines 0 comments Download
M content/browser/web_contents/aura/window_slider_unittest.cc View 5 chunks +5 lines, -3 lines 0 comments Download
M content/browser/web_contents/web_contents_view_aura_browsertest.cc View 2 chunks +0 lines, -10 lines 0 comments Download
M ui/aura/window_unittest.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M ui/compositor/compositor.h View 6 chunks +2 lines, -13 lines 0 comments Download
M ui/compositor/compositor.cc View 5 chunks +1 line, -15 lines 0 comments Download
M ui/compositor/compositor.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/compositor/layer.h View 2 chunks +0 lines, -7 lines 0 comments Download
M ui/compositor/layer.cc View 4 chunks +4 lines, -48 lines 0 comments Download
M ui/compositor/layer_animation_delegate.h View 2 chunks +0 lines, -3 lines 0 comments Download
M ui/compositor/layer_animator.h View 7 chunks +9 lines, -13 lines 0 comments Download
M ui/compositor/layer_animator.cc View 9 chunks +33 lines, -46 lines 0 comments Download
D ui/compositor/layer_animator_collection.h View 1 chunk +0 lines, -56 lines 0 comments Download
D ui/compositor/layer_animator_collection.cc View 1 chunk +0 lines, -56 lines 0 comments Download
M ui/compositor/layer_animator_unittest.cc View 80 chunks +108 lines, -203 lines 0 comments Download
M ui/compositor/layer_unittest.cc View 1 chunk +0 lines, -50 lines 0 comments Download
M ui/compositor/test/test_layer_animation_delegate.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/compositor/test/test_layer_animation_delegate.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M ui/keyboard/keyboard_controller_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
tzik
The CQ bit was checked by tzik@chromium.org
6 years, 6 months ago (2014-06-03 06:07:01 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tzik@chromium.org/311783002/1
6 years, 6 months ago (2014-06-03 06:08:41 UTC) #2
commit-bot: I haz the power
6 years, 6 months ago (2014-06-03 06:10:47 UTC) #3
Message was sent while issue was closed. 
Change committed as 274423

Powered by Google App Engine
This is Rietveld 408576698