Make VisiblePosition::FirstPositionInNode() to take const Node& instead of Node*

Make VisiblePosition::FirstPositionInNode() to take const Node& instead of Node*

This patch makes |VisiblePosition::FirstPositionInNode()| to take |const Node&|
as |Position::FirstPositionInNode()| for improving code health.

This is mechanical change:
s/VisiblePositon::FirstPositionInNode(/VisiblePositon::FirstPositionInNode(*/


BUG=n/a
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2955823002
Cr-Commit-Position: refs/heads/master@{#482237}
Committed: https://chromium.googlesource.com/chromium/src/+/cbf7050ee81b7ca0390e634cfd08f764f33f1307

[yosin_UTC9, 2017-06-26 04:58:36]

Description was changed from

==========
2017-06-26T13:57:23

BUG=

2017-06-26T13:57:19
==========

to

==========
Make VisiblePosition::FirstPositionInNode() to take const Node& instead of Node*

This patch makes |VisiblePosition::FirstPositionInNode()| to take |const Node&|
as |Position::FirstPositionInNode()| for improving code health.

This is mechanical change:
s/VisiblePositon::FirstPositionInNode(/VisiblePositon::FirstPositionInNode(*/


BUG=n/a
TEST=n/a; no behavior changes
==========

[yosin_UTC9, 2017-06-26 04:58:47]

The CQ bit was checked by yosin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-26 04:58:56]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-26 06:53:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-26 06:53:02]

Dry run: This issue passed the CQ dry run.

[yosin_UTC9, 2017-06-26 07:55:16]

yosin@chromium.org changed reviewers:
+ tkent@chromium.org

[yosin_UTC9, 2017-06-26 07:55:17]

PTAL

Including core/editing, core/html and core/svg

[tkent, 2017-06-26 08:08:22]

https://codereview.chromium.org/2955823002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp
(right):

https://codereview.chromium.org/2955823002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp:1070:
VisiblePosition::FirstPositionInNode(*new_block),
Is new_block always non-null?

https://codereview.chromium.org/2955823002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/editing/commands/DeleteSelectionCommand.cpp
(right):

https://codereview.chromium.org/2955823002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/commands/DeleteSelectionCommand.cpp:49:
static bool IsTableCellEmpty(Node* cell) {
Please make the |cell| argument |Node&|, or add |DCHECK(cell)|.
It's hard to confirm |cell| is never null at a glance.

[yosin_UTC9, 2017-06-26 08:53:24]

The CQ bit was checked by yosin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-26 08:53:36]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yosin_UTC9, 2017-06-26 08:53:52]

PTAL

Add DCHECKs

https://codereview.chromium.org/2955823002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp
(right):

https://codereview.chromium.org/2955823002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp:1070:
VisiblePosition::FirstPositionInNode(*new_block),
On 2017/06/26 at 08:08:22, tkent wrote:
> Is new_block always non-null?

Yes, |new_block| holds return value of InsertNewDefaultParagraphElementAt()
which is non-null
except for abort case.

I'll add DCHECK(new_block) for sane.

https://codereview.chromium.org/2955823002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/editing/commands/DeleteSelectionCommand.cpp
(right):

https://codereview.chromium.org/2955823002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/commands/DeleteSelectionCommand.cpp:49:
static bool IsTableCellEmpty(Node* cell) {
On 2017/06/26 at 08:08:22, tkent wrote:
> Please make the |cell| argument |Node&|, or add |DCHECK(cell)|.
> It's hard to confirm |cell| is never null at a glance.

Done.

[tkent, 2017-06-26 08:55:20]

lgtm

[yosin_UTC9, 2017-06-26 09:27:26]

The CQ bit was unchecked by yosin@chromium.org

[yosin_UTC9, 2017-06-26 09:27:29]

The CQ bit was checked by yosin@chromium.org

[commit-bot: I haz the power, 2017-06-26 09:27:38]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-26 10:57:52]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1498469249154360,
"parent_rev": "b4ef7c0fece5fdbf8d51f4a6865056a1b03298c8", "commit_rev":
"0c442e1219add2c46221b33377410a84506d94d6"}

[commit-bot: I haz the power, 2017-06-26 10:58:16]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1498469249154360,
"parent_rev": "09c04f87d103c9f0cfdddfaf5b024168e2276df6", "commit_rev":
"cbf7050ee81b7ca0390e634cfd08f764f33f1307"}

[commit-bot: I haz the power, 2017-06-26 10:58:26]

Description was changed from

==========
Make VisiblePosition::FirstPositionInNode() to take const Node& instead of Node*

This patch makes |VisiblePosition::FirstPositionInNode()| to take |const Node&|
as |Position::FirstPositionInNode()| for improving code health.

This is mechanical change:
s/VisiblePositon::FirstPositionInNode(/VisiblePositon::FirstPositionInNode(*/


BUG=n/a
TEST=n/a; no behavior changes
==========

to

==========
Make VisiblePosition::FirstPositionInNode() to take const Node& instead of Node*

This patch makes |VisiblePosition::FirstPositionInNode()| to take |const Node&|
as |Position::FirstPositionInNode()| for improving code health.

This is mechanical change:
s/VisiblePositon::FirstPositionInNode(/VisiblePositon::FirstPositionInNode(*/


BUG=n/a
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2955823002
Cr-Commit-Position: refs/heads/master@{#482237}
Committed:
https://chromium.googlesource.com/chromium/src/+/cbf7050ee81b7ca0390e634cfd08...
==========

[commit-bot: I haz the power, 2017-06-26 10:58:28]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/cbf7050ee81b7ca0390e634cfd08...