Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Unified Diff: third_party/WebKit/Source/core/editing/VisibleUnits.cpp

Issue 2955823002: Make VisiblePosition::FirstPositionInNode() to take const Node& instead of Node* (Closed)
Patch Set: 2017-06-26T17:50:06 Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/VisibleUnits.cpp
diff --git a/third_party/WebKit/Source/core/editing/VisibleUnits.cpp b/third_party/WebKit/Source/core/editing/VisibleUnits.cpp
index 868deaadf37992cf1a6fd3ded0c31678678f3ad0..13798f33ae528b8e660a9b4f4aee1e3cdea0adf7 100644
--- a/third_party/WebKit/Source/core/editing/VisibleUnits.cpp
+++ b/third_party/WebKit/Source/core/editing/VisibleUnits.cpp
@@ -549,7 +549,7 @@ VisiblePosition StartOfBlock(const VisiblePosition& visible_position,
position.ComputeContainerNode()
? EnclosingBlock(position.ComputeContainerNode(), rule)
: 0;
- return start_block ? VisiblePosition::FirstPositionInNode(start_block)
+ return start_block ? VisiblePosition::FirstPositionInNode(*start_block)
: VisiblePosition();
}
@@ -643,7 +643,7 @@ VisiblePosition StartOfEditableContent(
if (!highest_root)
return VisiblePosition();
- return VisiblePosition::FirstPositionInNode(highest_root);
+ return VisiblePosition::FirstPositionInNode(*highest_root);
}
VisiblePosition EndOfEditableContent(const VisiblePosition& visible_position) {

Powered by Google App Engine
This is Rietveld 408576698