Make VisiblePosition::FirstPositionInNode() to take const Node& instead of Node*

third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp

 /*
  * Copyright (C) 2005, 2006, 2007, 2008 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 1049 matching lines @@
   bool end_was_br =
       isHTMLBRElement(*visible_paragraph_end.DeepEquivalent().AnchorNode());
 
   // Inserting default paragraph element can change visible position. We
   // should update visible positions before use them.
   GetDocument().UpdateStyleAndLayoutIgnorePendingStylesheets();
   visible_pos = CreateVisiblePosition(pos, VP_DEFAULT_AFFINITY);
   visible_paragraph_start = StartOfParagraph(visible_pos);
   visible_paragraph_end = EndOfParagraph(visible_pos);
   MoveParagraphs(visible_paragraph_start, visible_paragraph_end,
-                 VisiblePosition::FirstPositionInNode(new_block),
+                 VisiblePosition::FirstPositionInNode(*new_block),

[tkent, 2017/06/26 08:08:22]

Is new_block always non-null?

[yosin_UTC9, 2017/06/26 08:53:52]

Yes, |new_block| holds return value of InsertNewDefaultParagraphElementAt()
which is non-null
except for abort case.

I'll add DCHECK(new_block) for sane.

                  editing_state);
   if (editing_state->IsAborted())
     return nullptr;
 
   if (new_block->lastChild() && isHTMLBRElement(*new_block->lastChild()) &&
       !end_was_br) {
     RemoveNode(new_block->lastChild(), editing_state);
     if (editing_state->IsAborted())
       return nullptr;
   }
@@ skipping 710 matching lines @@
   Element* enclosing_anchor = EnclosingAnchorElement(original);
   Position result = original;
 
   if (!enclosing_anchor)
     return result;
 
   // Don't avoid block level anchors, because that would insert content into the
   // wrong paragraph.
   if (enclosing_anchor && !IsEnclosingBlock(enclosing_anchor)) {
     VisiblePosition first_in_anchor =
-        VisiblePosition::FirstPositionInNode(enclosing_anchor);
+        VisiblePosition::FirstPositionInNode(*enclosing_anchor);
     VisiblePosition last_in_anchor =
         VisiblePosition::LastPositionInNode(enclosing_anchor);
     // If visually just after the anchor, insert *inside* the anchor unless it's
     // the last VisiblePosition in the document, to match NSTextView.
     if (visible_pos.DeepEquivalent() == last_in_anchor.DeepEquivalent()) {
       // Make sure anchors are pushed down before avoiding them so that we don't
       // also avoid structural elements like lists and blocks (5142012).
       if (original.AnchorNode() != enclosing_anchor &&
           original.AnchorNode()->parentNode() != enclosing_anchor) {
         PushAnchorElementDown(enclosing_anchor, editing_state);
@@ skipping 63 matching lines @@
   for (node = start; node->parentNode() != end_node;
        node = node->parentNode()) {
     Element* parent_element = node->parentElement();
     if (!parent_element)
       break;
 
     GetDocument().UpdateStyleAndLayoutIgnorePendingStylesheets();
 
     // Do not split a node when doing so introduces an empty node.
     VisiblePosition position_in_parent =
-        VisiblePosition::FirstPositionInNode(parent_element);
+        VisiblePosition::FirstPositionInNode(*parent_element);
     VisiblePosition position_in_node =
         CreateVisiblePosition(FirstPositionInOrBeforeNode(node));
     if (position_in_parent.DeepEquivalent() !=
         position_in_node.DeepEquivalent())
       SplitElement(parent_element, node);
   }
 
   return node;
 }
 
@@ skipping 78 matching lines @@
 
 DEFINE_TRACE(CompositeEditCommand) {
   visitor->Trace(commands_);
   visitor->Trace(starting_selection_);
   visitor->Trace(ending_selection_);
   visitor->Trace(undo_step_);
   EditCommand::Trace(visitor);
 }
 
 }  // namespace blink