third_party/WebKit/Source/core/html/TextControlElement.cpp - Issue 2955823002: Make VisiblePosition::FirstPositionInNode() to take const Node& instead of Node*

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/TextControlElement.cpp

Issue 2955823002: Make VisiblePosition::FirstPositionInNode() to take const Node& instead of Node* (Closed)

Patch Set: 2017-06-26T17:50:06 Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/html/TextControlElement.cpp

diff --git a/third_party/WebKit/Source/core/html/TextControlElement.cpp b/third_party/WebKit/Source/core/html/TextControlElement.cpp

index d05dac2d0005878ceda446a2f871fca6c263b76d..284c4111e1a86db4b5cb763b6ed663795295f32e 100644

--- a/third_party/WebKit/Source/core/html/TextControlElement.cpp

+++ b/third_party/WebKit/Source/core/html/TextControlElement.cpp

@@ -459,7 +459,7 @@ bool TextControlElement::CacheSelection(unsigned start,

VisiblePosition TextControlElement::VisiblePositionForIndex(int index) const {

if (index <= 0)

- return VisiblePosition::FirstPositionInNode(InnerEditorElement());

+ return VisiblePosition::FirstPositionInNode(*InnerEditorElement());

Position start, end;

bool selected = Range::selectNodeContents(InnerEditorElement(), start, end);

if (!selected)