third_party/WebKit/Source/core/editing/commands/DeleteSelectionCommand.cpp - Issue 2955823002: Make VisiblePosition::FirstPositionInNode() to take const Node& instead of Node*

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/commands/DeleteSelectionCommand.cpp

Issue 2955823002: Make VisiblePosition::FirstPositionInNode() to take const Node& instead of Node* (Closed)

Patch Set: 2017-06-26T17:50:06 Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp ('k') | third_party/WebKit/Source/core/editing/commands/IndentOutdentCommand.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/commands/DeleteSelectionCommand.cpp

diff --git a/third_party/WebKit/Source/core/editing/commands/DeleteSelectionCommand.cpp b/third_party/WebKit/Source/core/editing/commands/DeleteSelectionCommand.cpp

index c3d742efee6cddec3b66f3168d3f3b984da88eff..556169704b10b073771b8df683caaaa57e727a0b 100644

--- a/third_party/WebKit/Source/core/editing/commands/DeleteSelectionCommand.cpp

+++ b/third_party/WebKit/Source/core/editing/commands/DeleteSelectionCommand.cpp

@@ -47,8 +47,9 @@ namespace blink {

using namespace HTMLNames;

static bool IsTableCellEmpty(Node* cell) {

+ DCHECK(cell);

DCHECK(IsTableCell(cell)) << cell;

- return VisiblePosition::FirstPositionInNode(cell).DeepEquivalent() ==

+ return VisiblePosition::FirstPositionInNode(*cell).DeepEquivalent() ==

VisiblePosition::LastPositionInNode(cell).DeepEquivalent();

}

@@ -513,7 +514,7 @@ void DeleteSelectionCommand::RemoveNode(

GetDocument().UpdateStyleAndLayoutIgnorePendingStylesheets();

if (node == start_block_) {

VisiblePosition previous = PreviousPositionOf(

- VisiblePosition::FirstPositionInNode(start_block_.Get()));

+ VisiblePosition::FirstPositionInNode(*start_block_.Get()));

if (previous.IsNotNull() && !IsEndOfBlock(previous))

need_placeholder_ = true;

}