Make VisiblePosition::FirstPositionInNode() to take const Node& instead of Node*

third_party/WebKit/Source/core/editing/commands/DeleteSelectionCommand.cpp

 /*
  * Copyright (C) 2005 Apple Computer, Inc.  All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 28 matching lines @@
 #include "core/html/HTMLBRElement.h"
 #include "core/html/HTMLInputElement.h"
 #include "core/html/HTMLStyleElement.h"
 #include "core/html/HTMLTableRowElement.h"
 #include "core/layout/LayoutTableCell.h"
 
 namespace blink {
 
 using namespace HTMLNames;
 
 static bool IsTableCellEmpty(Node* cell) {

[tkent, 2017/06/26 08:08:22]

Please make the |cell| argument |Node&|, or add |DCHECK(cell)|.
It's hard to confirm |cell| is never null at a glance.

[yosin_UTC9, 2017/06/26 08:53:52]

Done.

   DCHECK(IsTableCell(cell)) << cell;
-  return VisiblePosition::FirstPositionInNode(cell).DeepEquivalent() ==
+  return VisiblePosition::FirstPositionInNode(*cell).DeepEquivalent() ==
          VisiblePosition::LastPositionInNode(cell).DeepEquivalent();
 }
 
 static bool IsTableRowEmpty(Node* row) {
   if (!isHTMLTableRowElement(row))
     return false;
 
   row->GetDocument().UpdateStyleAndLayoutIgnorePendingStylesheets();
   for (Node* child = row->firstChild(); child; child = child->nextSibling()) {
     if (IsTableCell(child) && !IsTableCellEmpty(child))
@@ skipping 444 matching lines @@
       Position first_editable_position = FirstEditablePositionInNode(node);
       if (first_editable_position.IsNotNull())
         InsertBlockPlaceholder(first_editable_position, editing_state);
     }
     return;
   }
 
   GetDocument().UpdateStyleAndLayoutIgnorePendingStylesheets();
   if (node == start_block_) {
     VisiblePosition previous = PreviousPositionOf(
-        VisiblePosition::FirstPositionInNode(start_block_.Get()));
+        VisiblePosition::FirstPositionInNode(*start_block_.Get()));
     if (previous.IsNotNull() && !IsEndOfBlock(previous))
       need_placeholder_ = true;
   }
   if (node == end_block_) {
     VisiblePosition next =
         NextPositionOf(VisiblePosition::LastPositionInNode(end_block_.Get()));
     if (next.IsNotNull() && !IsStartOfBlock(next))
       need_placeholder_ = true;
   }
 
@@ skipping 720 matching lines @@
   visitor->Trace(delete_into_blockquote_style_);
   visitor->Trace(start_root_);
   visitor->Trace(end_root_);
   visitor->Trace(start_table_row_);
   visitor->Trace(end_table_row_);
   visitor->Trace(temporary_placeholder_);
   CompositeEditCommand::Trace(visitor);
 }
 
 }  // namespace blink