MD Settings: Convert all browser proxies to use ES6 class syntax.

MD Settings: Convert all browser proxies to use ES6 class syntax.

The conversion has been performed automatically with a tool, followed
by minimal human editing on the tool's output.

BUG=671426
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2954863003
Cr-Commit-Position: refs/heads/master@{#482820}
Committed: https://chromium.googlesource.com/chromium/src/+/340ecaca61543a25037c176a91597429cbc29eef

[dpapad, 2017-06-26 20:33:11]

Description was changed from

==========
MD Settings: Convert all browser proxies to use ES6 class syntax, WIP.

BUG=
==========

to

==========
MD Settings: Convert all browser proxies to use ES6 class syntax, WIP.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dpapad, 2017-06-26 21:18:09]

The CQ bit was checked by dpapad@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-26 21:18:37]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-26 21:38:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-26 21:38:55]

Dry run: Try jobs failed on following builders:
  closure_compilation on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/closure_compila...)

[dpapad, 2017-06-26 21:45:31]

The CQ bit was checked by dpapad@chromium.org to run a CQ dry run

[dpapad, 2017-06-26 21:45:46]

Description was changed from

==========
MD Settings: Convert all browser proxies to use ES6 class syntax, WIP.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Convert all browser proxies to use ES6 class syntax.

BUG=None
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[commit-bot: I haz the power, 2017-06-26 21:45:56]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-26 23:07:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-26 23:07:51]

Dry run: This issue passed the CQ dry run.

[dpapad, 2017-06-27 00:43:20]

Description was changed from

==========
MD Settings: Convert all browser proxies to use ES6 class syntax.

BUG=None
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Convert all browser proxies to use ES6 class syntax.

The conversion has been performed automatically with a tool, and some
human editing on the tool's output.

BUG=None
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dpapad, 2017-06-27 00:44:38]

dpapad@chromium.org changed reviewers:
+ scottchen@chromium.org

[dpapad, 2017-06-27 00:45:24]

Description was changed from

==========
MD Settings: Convert all browser proxies to use ES6 class syntax.

The conversion has been performed automatically with a tool, and some
human editing on the tool's output.

BUG=None
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Convert all browser proxies to use ES6 class syntax.

The conversion has been performed automatically with a tool, followed
by minimal human editing on the tool's output.

BUG=None
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dpapad, 2017-06-27 21:06:17]

Description was changed from

==========
MD Settings: Convert all browser proxies to use ES6 class syntax.

The conversion has been performed automatically with a tool, followed
by minimal human editing on the tool's output.

BUG=None
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Convert all browser proxies to use ES6 class syntax.

The conversion has been performed automatically with a tool, followed
by minimal human editing on the tool's output.

BUG=671426
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[scottchen, 2017-06-27 21:14:10]

LGTM, excited to see ES6 back in action.

https://codereview.chromium.org/2954863003/diff/120001/chrome/browser/resourc...
File chrome/browser/resources/settings/appearance_page/fonts_browser_proxy.js
(left):

https://codereview.chromium.org/2954863003/diff/120001/chrome/browser/resourc...
chrome/browser/resources/settings/appearance_page/fonts_browser_proxy.js:26:
openAdvancedFontSettings: assertNotReached,
for future readers:
Had a discussion with @dpapad about assertNotReached logic being removed, and
concluded that we didn't need it originally anyway, because the implementations
wasn't doing actual sub-classing, so the methods were not gonna fall through
anyway.

[dpapad, 2017-06-27 21:29:18]

The CQ bit was checked by dpapad@chromium.org

[commit-bot: I haz the power, 2017-06-27 21:29:45]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-27 22:06:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-27 22:06:23]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[dpapad, 2017-06-27 23:28:27]

The CQ bit was checked by dpapad@chromium.org

[commit-bot: I haz the power, 2017-06-27 23:28:49]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-28 00:37:06]

CQ is committing da patch.

Bot data: {"patchset_id": 120001, "attempt_start_ts": 1498606107171330,
"parent_rev": "91e2d1a791aada23704d812f40f6a29421cdb434", "commit_rev":
"340ecaca61543a25037c176a91597429cbc29eef"}

[commit-bot: I haz the power, 2017-06-28 00:37:20]

Description was changed from

==========
MD Settings: Convert all browser proxies to use ES6 class syntax.

The conversion has been performed automatically with a tool, followed
by minimal human editing on the tool's output.

BUG=671426
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Convert all browser proxies to use ES6 class syntax.

The conversion has been performed automatically with a tool, followed
by minimal human editing on the tool's output.

BUG=671426
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2954863003
Cr-Commit-Position: refs/heads/master@{#482820}
Committed:
https://chromium.googlesource.com/chromium/src/+/340ecaca61543a25037c176a9159...
==========

[commit-bot: I haz the power, 2017-06-28 00:37:22]

Committed patchset #7 (id:120001) as
https://chromium.googlesource.com/chromium/src/+/340ecaca61543a25037c176a9159...