Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(673)

Unified Diff: chrome/browser/resources/settings/appearance_page/appearance_browser_proxy.js

Issue 2954863003: MD Settings: Convert all browser proxies to use ES6 class syntax. (Closed)
Patch Set: Remove @constructor annotations. Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/appearance_page/appearance_browser_proxy.js
diff --git a/chrome/browser/resources/settings/appearance_page/appearance_browser_proxy.js b/chrome/browser/resources/settings/appearance_page/appearance_browser_proxy.js
index 5006a3f41fef4564e6e1ffcab3e7e4c41941d01e..779818bd13a405ed971f00a6a5c0b95a42f06f3a 100644
--- a/chrome/browser/resources/settings/appearance_page/appearance_browser_proxy.js
+++ b/chrome/browser/resources/settings/appearance_page/appearance_browser_proxy.js
@@ -4,90 +4,89 @@
cr.define('settings', function() {
/** @interface */
- function AppearanceBrowserProxy() {}
-
- AppearanceBrowserProxy.prototype = {
+ class AppearanceBrowserProxy {
/** @return {!Promise<number>} */
- getDefaultZoom: assertNotReached,
+ getDefaultZoom() {}
/**
* @param {string} themeId
* @return {!Promise<!chrome.management.ExtensionInfo>} Theme info.
*/
- getThemeInfo: assertNotReached,
+ getThemeInfo(themeId) {}
/** @return {boolean} Whether the current profile is supervised. */
- isSupervised: assertNotReached,
+ isSupervised() {}
// <if expr="chromeos">
- openWallpaperManager: assertNotReached,
+ openWallpaperManager() {}
+
// </if>
- useDefaultTheme: assertNotReached,
+ useDefaultTheme() {}
// <if expr="is_linux and not chromeos">
- useSystemTheme: assertNotReached,
+ useSystemTheme() {}
+
// </if>
/**
* @param {string} url The url of which to check validity.
* @return {!Promise<boolean>}
*/
- validateStartupPage: assertNotReached,
- };
+ validateStartupPage(url) {}
+ }
/**
* @implements {settings.AppearanceBrowserProxy}
- * @constructor
*/
- function AppearanceBrowserProxyImpl() {}
-
- cr.addSingletonGetter(AppearanceBrowserProxyImpl);
-
- AppearanceBrowserProxyImpl.prototype = {
+ class AppearanceBrowserProxyImpl {
/** @override */
- getDefaultZoom: function() {
+ getDefaultZoom() {
return new Promise(function(resolve) {
chrome.settingsPrivate.getDefaultZoom(resolve);
});
- },
+ }
/** @override */
- getThemeInfo: function(themeId) {
+ getThemeInfo(themeId) {
return new Promise(function(resolve) {
chrome.management.get(themeId, resolve);
});
- },
+ }
/** @override */
- isSupervised: function() {
+ isSupervised() {
return loadTimeData.getBoolean('isSupervised');
- },
+ }
// <if expr="chromeos">
/** @override */
- openWallpaperManager: function() {
+ openWallpaperManager() {
chrome.send('openWallpaperManager');
- },
+ }
+
// </if>
/** @override */
- useDefaultTheme: function() {
+ useDefaultTheme() {
chrome.send('useDefaultTheme');
- },
+ }
// <if expr="is_linux and not chromeos">
/** @override */
- useSystemTheme: function() {
+ useSystemTheme() {
chrome.send('useSystemTheme');
- },
+ }
+
// </if>
/** @override */
- validateStartupPage: function(url) {
+ validateStartupPage(url) {
return cr.sendWithPromise('validateStartupPage', url);
- },
- };
+ }
+ }
+
+ cr.addSingletonGetter(AppearanceBrowserProxyImpl);
return {
AppearanceBrowserProxy: AppearanceBrowserProxy,

Powered by Google App Engine
This is Rietveld 408576698