Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2086)

Unified Diff: chrome/browser/resources/settings/people_page/fingerprint_browser_proxy.js

Issue 2954863003: MD Settings: Convert all browser proxies to use ES6 class syntax. (Closed)
Patch Set: Remove @constructor annotations. Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/people_page/fingerprint_browser_proxy.js
diff --git a/chrome/browser/resources/settings/people_page/fingerprint_browser_proxy.js b/chrome/browser/resources/settings/people_page/fingerprint_browser_proxy.js
index 09e2f8c080d65a09335dcd5587329975d2489097..71941a3a5aa75d0ffc2658cb0929de26f8a021ad 100644
--- a/chrome/browser/resources/settings/people_page/fingerprint_browser_proxy.js
+++ b/chrome/browser/resources/settings/people_page/fingerprint_browser_proxy.js
@@ -52,112 +52,106 @@ settings.FingerprintInfo;
cr.define('settings', function() {
/** @interface */
- function FingerprintBrowserProxy() {}
-
- FingerprintBrowserProxy.prototype = {
+ class FingerprintBrowserProxy {
/**
* @return {!Promise<!settings.FingerprintInfo>}
*/
- getFingerprintsList: function() {},
+ getFingerprintsList() {}
/**
* @return {!Promise<number>}
*/
- getNumFingerprints: function() {},
-
- startEnroll: function() {},
+ getNumFingerprints() {}
- cancelCurrentEnroll: function() {},
+ startEnroll() {}
+ cancelCurrentEnroll() {}
/**
* @param {number} index
* @return {!Promise<string>}
*/
- getEnrollmentLabel: function(index) {},
+ getEnrollmentLabel(index) {}
/**
* @param {number} index
* @return {!Promise<boolean>}
*/
- removeEnrollment: function(index) {},
+ removeEnrollment(index) {}
/**
* @param {number} index
* @param {string} newLabel
* @return {!Promise<boolean>}
*/
- changeEnrollmentLabel: function(index, newLabel) {},
-
- startAuthentication: function() {},
+ changeEnrollmentLabel(index, newLabel) {}
- endCurrentAuthentication: function() {},
+ startAuthentication() {}
+ endCurrentAuthentication() {}
/**
* TODO(sammiequon): Temporary function to let the handler know when a
* completed scan has been sent via click on the setup fingerprint dialog.
* Remove this when real scans are implemented.
*/
- fakeScanComplete: function() {},
- };
+ fakeScanComplete() {}
+ }
/**
- * @constructor
* @implements {settings.FingerprintBrowserProxy}
*/
- function FingerprintBrowserProxyImpl() {}
- cr.addSingletonGetter(FingerprintBrowserProxyImpl);
-
- FingerprintBrowserProxyImpl.prototype = {
+ class FingerprintBrowserProxyImpl {
/** @override */
- getFingerprintsList: function() {
+ getFingerprintsList() {
return cr.sendWithPromise('getFingerprintsList');
- },
+ }
/** @override */
- getNumFingerprints: function() {
+ getNumFingerprints() {
return cr.sendWithPromise('getNumFingerprints');
- },
+ }
/** @override */
- startEnroll: function() {
+ startEnroll() {
chrome.send('startEnroll');
- },
+ }
/** @override */
- cancelCurrentEnroll: function() {
+ cancelCurrentEnroll() {
chrome.send('cancelCurrentEnroll');
- },
+ }
/** @override */
- getEnrollmentLabel: function(index) {
+ getEnrollmentLabel(index) {
return cr.sendWithPromise('getEnrollmentLabel');
- },
+ }
/** @override */
- removeEnrollment: function(index) {
+ removeEnrollment(index) {
return cr.sendWithPromise('removeEnrollment', index);
- },
+ }
/** @override */
- changeEnrollmentLabel: function(index, newLabel) {
+ changeEnrollmentLabel(index, newLabel) {
return cr.sendWithPromise('changeEnrollmentLabel', index, newLabel);
- },
+ }
/** @override */
- startAuthentication: function() {
+ startAuthentication() {
chrome.send('startAuthentication');
- },
+ }
/** @override */
- endCurrentAuthentication: function() {
+ endCurrentAuthentication() {
chrome.send('endCurrentAuthentication');
- },
+ }
/** @override */
- fakeScanComplete: function() {
+ fakeScanComplete() {
chrome.send('fakeScanComplete');
- },
- };
+ }
+ }
+
+ cr.addSingletonGetter(FingerprintBrowserProxyImpl);
return {
FingerprintBrowserProxy: FingerprintBrowserProxy,

Powered by Google App Engine
This is Rietveld 408576698