Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(866)

Unified Diff: chrome/browser/resources/settings/languages_page/languages_browser_proxy.js

Issue 2954863003: MD Settings: Convert all browser proxies to use ES6 class syntax. (Closed)
Patch Set: Remove @constructor annotations. Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/languages_page/languages_browser_proxy.js
diff --git a/chrome/browser/resources/settings/languages_page/languages_browser_proxy.js b/chrome/browser/resources/settings/languages_page/languages_browser_proxy.js
index 5edc03f68818896fe50419be82d634b27f38aff1..e23dd2500694c3a6f8d73ddefe2892c17652f2ab 100644
--- a/chrome/browser/resources/settings/languages_page/languages_browser_proxy.js
+++ b/chrome/browser/resources/settings/languages_page/languages_browser_proxy.js
@@ -9,65 +9,63 @@
cr.define('settings', function() {
/** @interface */
- function LanguagesBrowserProxy() {}
-
- LanguagesBrowserProxy.prototype = {
+ class LanguagesBrowserProxy {
// <if expr="chromeos or is_win">
/**
* Sets the prospective UI language to the chosen language. This won't
* affect the actual UI language until a restart.
* @param {string} languageCode
*/
- setProspectiveUILanguage: function(languageCode) {},
+ setProspectiveUILanguage(languageCode) {}
/** @return {!Promise<string>} */
- getProspectiveUILanguage: function() {},
+ getProspectiveUILanguage() {}
+
// </if>
/** @return {!LanguageSettingsPrivate} */
- getLanguageSettingsPrivate: function() {},
+ getLanguageSettingsPrivate() {}
// <if expr="chromeos">
/** @return {!InputMethodPrivate} */
- getInputMethodPrivate: function() {},
+ getInputMethodPrivate() {}
// </if>
- };
+ }
/**
- * @constructor
* @implements {settings.LanguagesBrowserProxy}
*/
- function LanguagesBrowserProxyImpl() {}
- // The singleton instance_ is replaced with a test version of this wrapper
- // during testing.
- cr.addSingletonGetter(LanguagesBrowserProxyImpl);
-
- LanguagesBrowserProxyImpl.prototype = {
+ class LanguagesBrowserProxyImpl {
// <if expr="chromeos or is_win">
/** @override */
- setProspectiveUILanguage: function(languageCode) {
+ setProspectiveUILanguage(languageCode) {
chrome.send('setProspectiveUILanguage', [languageCode]);
- },
+ }
/** @override */
- getProspectiveUILanguage: function() {
+ getProspectiveUILanguage() {
return cr.sendWithPromise('getProspectiveUILanguage');
- },
+ }
+
// </if>
/** @override */
- getLanguageSettingsPrivate: function() {
+ getLanguageSettingsPrivate() {
return /** @type {!LanguageSettingsPrivate} */ (
chrome.languageSettingsPrivate);
- },
+ }
// <if expr="chromeos">
/** @override */
- getInputMethodPrivate: function() {
+ getInputMethodPrivate() {
return /** @type {!InputMethodPrivate} */ (chrome.inputMethodPrivate);
- },
+ }
// </if>
- };
+ }
+
+ // The singleton instance_ is replaced with a test version of this wrapper
+ // during testing.
+ cr.addSingletonGetter(LanguagesBrowserProxyImpl);
return {
LanguagesBrowserProxy: LanguagesBrowserProxy,

Powered by Google App Engine
This is Rietveld 408576698