Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6311)

Unified Diff: chrome/browser/resources/settings/extension_control_browser_proxy.js

Issue 2954863003: MD Settings: Convert all browser proxies to use ES6 class syntax. (Closed)
Patch Set: Remove @constructor annotations. Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/extension_control_browser_proxy.js
diff --git a/chrome/browser/resources/settings/extension_control_browser_proxy.js b/chrome/browser/resources/settings/extension_control_browser_proxy.js
index adbbd794efd8b29b8a263eafd8e29b3e39b62bf9..84b350ef2dbcfb16affc411e513c5b302bf574cc 100644
--- a/chrome/browser/resources/settings/extension_control_browser_proxy.js
+++ b/chrome/browser/resources/settings/extension_control_browser_proxy.js
@@ -4,36 +4,32 @@
cr.define('settings', function() {
/** @interface */
- function ExtensionControlBrowserProxy() {}
-
- ExtensionControlBrowserProxy.prototype = {
+ class ExtensionControlBrowserProxy {
// TODO(dbeam): should be be returning !Promise<boolean> to indicate whether
// it succeeded?
/** @param {string} extensionId */
- disableExtension: assertNotReached,
+ disableExtension(extensionId) {}
/** @param {string} extensionId */
- manageExtension: assertNotReached,
- };
+ manageExtension(extensionId) {}
+ }
/**
* @implements {settings.ExtensionControlBrowserProxy}
- * @constructor
*/
- function ExtensionControlBrowserProxyImpl() {}
- cr.addSingletonGetter(ExtensionControlBrowserProxyImpl);
-
- ExtensionControlBrowserProxyImpl.prototype = {
+ class ExtensionControlBrowserProxyImpl {
/** @override */
- disableExtension: function(extensionId) {
+ disableExtension(extensionId) {
chrome.send('disableExtension', [extensionId]);
- },
+ }
/** @override */
- manageExtension: function(extensionId) {
+ manageExtension(extensionId) {
window.open('chrome://extensions?id=' + extensionId);
- },
- };
+ }
+ }
+
+ cr.addSingletonGetter(ExtensionControlBrowserProxyImpl);
return {
ExtensionControlBrowserProxy: ExtensionControlBrowserProxy,

Powered by Google App Engine
This is Rietveld 408576698