Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Unified Diff: chrome/browser/resources/settings/on_startup_page/startup_urls_page_browser_proxy.js

Issue 2954863003: MD Settings: Convert all browser proxies to use ES6 class syntax. (Closed)
Patch Set: Remove @constructor annotations. Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/on_startup_page/startup_urls_page_browser_proxy.js
diff --git a/chrome/browser/resources/settings/on_startup_page/startup_urls_page_browser_proxy.js b/chrome/browser/resources/settings/on_startup_page/startup_urls_page_browser_proxy.js
index b33e31ae931c13efe1325480a06b6f9dfd1dd163..ff13b193046a1dbd0b415fbfd3b875fd6e85a8ce 100644
--- a/chrome/browser/resources/settings/on_startup_page/startup_urls_page_browser_proxy.js
+++ b/chrome/browser/resources/settings/on_startup_page/startup_urls_page_browser_proxy.js
@@ -14,25 +14,22 @@ var StartupPageInfo;
cr.define('settings', function() {
/** @interface */
- function StartupUrlsPageBrowserProxy() {}
-
- StartupUrlsPageBrowserProxy.prototype = {
- loadStartupPages: assertNotReached,
-
- useCurrentPages: assertNotReached,
+ class StartupUrlsPageBrowserProxy {
+ loadStartupPages() {}
+ useCurrentPages() {}
/**
* @param {string} url
* @return {!Promise<boolean>} Whether the URL is valid.
*/
- validateStartupPage: assertNotReached,
+ validateStartupPage(url) {}
/**
* @param {string} url
* @return {!Promise<boolean>} Whether the URL was actually added, or
* ignored because it was invalid.
*/
- addStartupPage: assertNotReached,
+ addStartupPage(url) {}
/**
* @param {number} modelIndex
@@ -40,51 +37,48 @@ cr.define('settings', function() {
* @return {!Promise<boolean>} Whether the URL was actually edited, or
* ignored because it was invalid.
*/
- editStartupPage: assertNotReached,
+ editStartupPage(modelIndex, url) {}
/** @param {number} index */
- removeStartupPage: assertNotReached,
- };
+ removeStartupPage(index) {}
+ }
/**
* @implements {settings.StartupUrlsPageBrowserProxy}
- * @constructor
*/
- function StartupUrlsPageBrowserProxyImpl() {}
-
- cr.addSingletonGetter(StartupUrlsPageBrowserProxyImpl);
-
- StartupUrlsPageBrowserProxyImpl.prototype = {
+ class StartupUrlsPageBrowserProxyImpl {
/** @override */
- loadStartupPages: function() {
+ loadStartupPages() {
chrome.send('onStartupPrefsPageLoad');
- },
+ }
/** @override */
- useCurrentPages: function() {
+ useCurrentPages() {
chrome.send('setStartupPagesToCurrentPages');
- },
+ }
/** @override */
- validateStartupPage: function(url) {
+ validateStartupPage(url) {
return cr.sendWithPromise('validateStartupPage', url);
- },
+ }
/** @override */
- addStartupPage: function(url) {
+ addStartupPage(url) {
return cr.sendWithPromise('addStartupPage', url);
- },
+ }
/** @override */
- editStartupPage: function(modelIndex, url) {
+ editStartupPage(modelIndex, url) {
return cr.sendWithPromise('editStartupPage', modelIndex, url);
- },
+ }
/** @override */
- removeStartupPage: function(index) {
+ removeStartupPage(index) {
chrome.send('removeStartupPage', [index]);
- },
- };
+ }
+ }
+
+ cr.addSingletonGetter(StartupUrlsPageBrowserProxyImpl);
return {
StartupUrlsPageBrowserProxy: StartupUrlsPageBrowserProxy,

Powered by Google App Engine
This is Rietveld 408576698