[Sync] Make children messages of UserEventSpecifics' consistent use event suffix.

[Sync] Make children messages of UserEventSpecifics' consistent use event suffix.

Inside of the UserEventSpecifics proto each potential field of the
oneof should use _event as a suffix of the field name, but none of the
message classes that are held by these _event fields should have Event
as a suffix of the message name.

BUG=701032
Review-Url: https://codereview.chromium.org/2942703002
Cr-Commit-Position: refs/heads/master@{#482622}
Committed: https://chromium.googlesource.com/chromium/src/+/429fbf04787c234d18effd06a0d50d184e67ecde

[skym, 2017-06-14 18:10:06]

The CQ bit was checked by skym@chromium.org to run a CQ dry run

[skym, 2017-06-14 18:10:24]

skym@chromium.org changed reviewers:
+ bartekg@chromium.org

[commit-bot: I haz the power, 2017-06-14 18:10:42]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-14 20:03:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-14 20:03:59]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[bartekg, 2017-06-16 04:02:30]

https://codereview.chromium.org/2942703002/diff/1/components/sync/protocol/us...
File components/sync/protocol/user_event_specifics.proto (right):

https://codereview.chromium.org/2942703002/diff/1/components/sync/protocol/us...
components/sync/protocol/user_event_specifics.proto:90: LanguageDetection
language_detection = 10;
An alternative would be to rename all fields in this oneof to foo_event

Maybe it would make it easier to distinguish them from other fields in the code?

[skym, 2017-06-19 21:29:07]

Is this what you were thinking Bartek?

https://codereview.chromium.org/2942703002/diff/1/components/sync/protocol/us...
File components/sync/protocol/user_event_specifics.proto (right):

https://codereview.chromium.org/2942703002/diff/1/components/sync/protocol/us...
components/sync/protocol/user_event_specifics.proto:90: LanguageDetection
language_detection = 10;
On 2017/06/16 04:02:30, bartekg wrote:
> An alternative would be to rename all fields in this oneof to foo_event
> 
> Maybe it would make it easier to distinguish them from other fields in the
code?

Done.

[skym, 2017-06-19 21:29:11]

The CQ bit was checked by skym@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-19 21:29:49]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-19 22:37:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-19 22:37:43]

Dry run: This issue passed the CQ dry run.

[bartekg, 2017-06-21 18:47:16]

lgtm

[skym, 2017-06-21 18:48:11]

skym@chromium.org changed reviewers:
+ pnoland@chromium.org

[skym, 2017-06-21 18:48:13]

PTAL pnoland

[Patrick Noland, 2017-06-21 18:51:59]

lgtm

[skym, 2017-06-21 19:38:34]

The CQ bit was checked by skym@chromium.org

[commit-bot: I haz the power, 2017-06-21 19:38:56]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-21 19:48:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-21 19:48:12]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[skym, 2017-06-21 23:38:14]

skym@chromium.org changed reviewers:
+ groby@chromium.org

[skym, 2017-06-21 23:38:15]

+groby for translate OWNERS, +renjieliu as FYI

[skym, 2017-06-26 18:42:27]

Friendly ping groby@, this is just renaming.

[skym, 2017-06-26 21:29:28]

The CQ bit was checked by skym@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-26 21:30:04]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[skym, 2017-06-26 23:05:27]

+napper for components/translate/OWNERS as groby seems to be OOO

[skym, 2017-06-26 23:06:49]

Description was changed from

==========
[Sync] Make children messages of UserEventSpecifics' names consistent by
removing 'Event'.

BUG=701032
==========

to

==========
[Sync] Make children messages of UserEventSpecifics' consistent use event
suffix.

Inside of the UserEventSpecifics proto each potential field of the
oneof should use _event as a suffix of the field name, but none of the
message classes that are held by these _event fields should have Event
as a suffix of the message name.

BUG=701032
==========

[commit-bot: I haz the power, 2017-06-26 23:11:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-26 23:11:20]

Dry run: This issue passed the CQ dry run.

[renjieliu1, 2017-06-27 00:08:04]

renjieliu@chromium.org changed reviewers:
+ napper@chromium.org

[renjieliu1, 2017-06-27 00:08:59]

renjieliu@chromium.org changed reviewers:
+ renjieliu@chromium.org

[renjieliu1, 2017-06-27 00:09:00]

add napper@ for owner review :)

[napper, 2017-06-27 01:28:52]

lgtm

[groby-ooo-7-16, 2017-06-27 09:13:38]

lgtm

[skym, 2017-06-27 14:32:50]

The CQ bit was checked by skym@chromium.org

[skym, 2017-06-27 14:32:51]

The patchset sent to the CQ was uploaded after l-g-t-m from
bartekg@chromium.org, pnoland@chromium.org
Link to the patchset: https://codereview.chromium.org/2942703002/#ps40001
(title: "Rebase")

[commit-bot: I haz the power, 2017-06-27 14:32:57]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-27 14:35:53]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1498573970728560,
"parent_rev": "f06bfc089846a2175801cf7d249f292cfb337940", "commit_rev":
"429fbf04787c234d18effd06a0d50d184e67ecde"}

[commit-bot: I haz the power, 2017-06-27 14:36:07]

Description was changed from

==========
[Sync] Make children messages of UserEventSpecifics' consistent use event
suffix.

Inside of the UserEventSpecifics proto each potential field of the
oneof should use _event as a suffix of the field name, but none of the
message classes that are held by these _event fields should have Event
as a suffix of the message name.

BUG=701032
==========

to

==========
[Sync] Make children messages of UserEventSpecifics' consistent use event
suffix.

Inside of the UserEventSpecifics proto each potential field of the
oneof should use _event as a suffix of the field name, but none of the
message classes that are held by these _event fields should have Event
as a suffix of the message name.

BUG=701032

Review-Url: https://codereview.chromium.org/2942703002
Cr-Commit-Position: refs/heads/master@{#482622}
Committed:
https://chromium.googlesource.com/chromium/src/+/429fbf04787c234d18effd06a0d5...
==========

[commit-bot: I haz the power, 2017-06-27 14:36:08]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/429fbf04787c234d18effd06a0d5...