Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Side by Side Diff: components/sync/protocol/proto_visitors.h

Issue 2942703002: [Sync] Make children messages of UserEventSpecifics' consistent use event suffix. (Closed)
Patch Set: Rebase Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | components/sync/protocol/user_event_specifics.proto » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_SYNC_PROTOCOL_PROTO_VISITORS_H_ 5 #ifndef COMPONENTS_SYNC_PROTOCOL_PROTO_VISITORS_H_
6 #define COMPONENTS_SYNC_PROTOCOL_PROTO_VISITORS_H_ 6 #define COMPONENTS_SYNC_PROTOCOL_PROTO_VISITORS_H_
7 7
8 #include "components/sync/protocol/app_list_specifics.pb.h" 8 #include "components/sync/protocol/app_list_specifics.pb.h"
9 #include "components/sync/protocol/app_notification_specifics.pb.h" 9 #include "components/sync/protocol/app_notification_specifics.pb.h"
10 #include "components/sync/protocol/app_setting_specifics.pb.h" 10 #include "components/sync/protocol/app_setting_specifics.pb.h"
(...skipping 454 matching lines...) Expand 10 before | Expand all | Expand 10 after
465 VISIT(enabled); 465 VISIT(enabled);
466 VISIT(favicon_sync_limit); 466 VISIT(favicon_sync_limit);
467 } 467 }
468 468
469 VISIT_PROTO_FIELDS(const sync_pb::FaviconTrackingSpecifics& proto) { 469 VISIT_PROTO_FIELDS(const sync_pb::FaviconTrackingSpecifics& proto) {
470 VISIT(favicon_url); 470 VISIT(favicon_url);
471 VISIT(last_visit_time_ms); 471 VISIT(last_visit_time_ms);
472 VISIT(is_bookmarked); 472 VISIT(is_bookmarked);
473 } 473 }
474 474
475 VISIT_PROTO_FIELDS(const sync_pb::FieldTrialEvent::FieldTrial& proto) { 475 VISIT_PROTO_FIELDS(const sync_pb::FieldTrial::FieldTrialPair& proto) {
476 VISIT(name_id); 476 VISIT(name_id);
477 VISIT(group_id); 477 VISIT(group_id);
478 } 478 }
479 479
480 VISIT_PROTO_FIELDS(const sync_pb::FieldTrialEvent& proto) { 480 VISIT_PROTO_FIELDS(const sync_pb::FieldTrial& proto) {
481 VISIT_REP(field_trials); 481 VISIT_REP(field_trial_pairs);
482 } 482 }
483 483
484 VISIT_PROTO_FIELDS(const sync_pb::GcmChannelFlags& proto) { 484 VISIT_PROTO_FIELDS(const sync_pb::GcmChannelFlags& proto) {
485 VISIT(enabled); 485 VISIT(enabled);
486 } 486 }
487 487
488 VISIT_PROTO_FIELDS(const sync_pb::GcmInvalidationsFlags& proto) { 488 VISIT_PROTO_FIELDS(const sync_pb::GcmInvalidationsFlags& proto) {
489 VISIT(enabled); 489 VISIT(enabled);
490 } 490 }
491 491
(...skipping 378 matching lines...) Expand 10 before | Expand all | Expand 10 after
870 VISIT_BYTES(value); 870 VISIT_BYTES(value);
871 VISIT_BYTES(compressed_value); 871 VISIT_BYTES(compressed_value);
872 VISIT(uncompressed_length); 872 VISIT(uncompressed_length);
873 VISIT_BYTES(custom_compressed_v1); 873 VISIT_BYTES(custom_compressed_v1);
874 } 874 }
875 875
876 VISIT_PROTO_FIELDS(const sync_pb::UserEventSpecifics& proto) { 876 VISIT_PROTO_FIELDS(const sync_pb::UserEventSpecifics& proto) {
877 VISIT(event_time_usec); 877 VISIT(event_time_usec);
878 VISIT(navigation_id); 878 VISIT(navigation_id);
879 VISIT(session_id); 879 VISIT(session_id);
880 VISIT(test); 880 VISIT(test_event);
881 VISIT(field_trial_event); 881 VISIT(field_trial_event);
882 VISIT(language_detection); 882 VISIT(language_detection_event);
883 VISIT(translation); 883 VISIT(translation_event);
884 } 884 }
885 885
886 VISIT_PROTO_FIELDS(const sync_pb::UserEventSpecifics::Test& proto) {} 886 VISIT_PROTO_FIELDS(const sync_pb::UserEventSpecifics::Test& proto) {}
887 887
888 VISIT_PROTO_FIELDS(const sync_pb::WalletMaskedCreditCard& proto) { 888 VISIT_PROTO_FIELDS(const sync_pb::WalletMaskedCreditCard& proto) {
889 VISIT(id); 889 VISIT(id);
890 VISIT_ENUM(status); 890 VISIT_ENUM(status);
891 VISIT(name_on_card); 891 VISIT(name_on_card);
892 VISIT_ENUM(type); 892 VISIT_ENUM(type);
893 VISIT(last_four); 893 VISIT(last_four);
(...skipping 41 matching lines...) Expand 10 before | Expand all | Expand 10 after
935 935
936 } // namespace syncer 936 } // namespace syncer
937 937
938 #undef VISIT_ 938 #undef VISIT_
939 #undef VISIT_BYTES 939 #undef VISIT_BYTES
940 #undef VISIT_ENUM 940 #undef VISIT_ENUM
941 #undef VISIT 941 #undef VISIT
942 #undef VISIT_REP 942 #undef VISIT_REP
943 943
944 #endif // COMPONENTS_SYNC_PROTOCOL_PROTO_VISITORS_H_ 944 #endif // COMPONENTS_SYNC_PROTOCOL_PROTO_VISITORS_H_
OLDNEW
« no previous file with comments | « no previous file | components/sync/protocol/user_event_specifics.proto » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698