components/translate/core/common/language_detection_logging_helper.cc - Issue 2942703002: [Sync] Make children messages of UserEventSpecifics' consistent use event suffix.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/translate/core/common/language_detection_logging_helper.cc

Issue 2942703002: [Sync] Make children messages of UserEventSpecifics' consistent use event suffix. (Closed)

Patch Set: Rebase Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/sync/protocol/user_event_specifics.proto ('k') | components/translate/core/common/language_detection_logging_helper_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/translate/core/common/language_detection_logging_helper.cc

diff --git a/components/translate/core/common/language_detection_logging_helper.cc b/components/translate/core/common/language_detection_logging_helper.cc

index b98ae8549c6769d7f21e73d65367ec1c4f5a74d5..1f29dc3df31ba6e49af981524e7e112c97873f4c 100644

--- a/components/translate/core/common/language_detection_logging_helper.cc

+++ b/components/translate/core/common/language_detection_logging_helper.cc

@@ -31,8 +31,8 @@ std::unique_ptr<sync_pb::UserEventSpecifics> ConstructLanguageDetectionEvent(

if (details.adopted_language != details.cld_language) {

lang_detection.set_adopted_language_code(details.adopted_language);

}

- *specifics->mutable_language_detection() = lang_detection;

+ *specifics->mutable_language_detection_event() = lang_detection;

return specifics;

}

-} // namespace translate

+} // namespace translate