Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Issue 2938813003: [Sync] Nest UserEvent message classes within UserEventSpecifics. (Closed)

Created:
3 years, 6 months ago by skym
Modified:
3 years, 5 months ago
CC:
chromium-reviews, renjieliu1, sync-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Sync] Nest UserEvent message classes within UserEventSpecifics. BUG=701032 Review-Url: https://codereview.chromium.org/2938813003 Cr-Commit-Position: refs/heads/master@{#483232} Committed: https://chromium.googlesource.com/chromium/src/+/212fbe9a6ef5c131b91d5719948c74061caa3a8a

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+101 lines, -91 lines) Patch
M components/sync/protocol/proto_enum_conversions.h View 1 chunk +2 lines, -1 line 0 comments Download
M components/sync/protocol/proto_enum_conversions.cc View 1 2 1 chunk +15 lines, -12 lines 0 comments Download
M components/sync/protocol/proto_visitors.h View 1 3 chunks +8 lines, -5 lines 0 comments Download
M components/sync/protocol/user_event_specifics.proto View 1 2 2 chunks +61 lines, -58 lines 0 comments Download
M components/translate/core/common/language_detection_logging_helper.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M components/translate/core/common/language_detection_logging_helper_unittest.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M components/translate/core/common/translation_logging_helper.cc View 1 2 3 chunks +11 lines, -11 lines 0 comments Download
M components/translate/core/common/translation_logging_helper_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 28 (19 generated)
skym
3 years, 6 months ago (2017-06-14 18:10:30 UTC) #4
bartekg
lgtm
3 years, 6 months ago (2017-06-21 18:48:23 UTC) #7
skym
PTAL
3 years, 6 months ago (2017-06-22 20:43:22 UTC) #10
Patrick Noland
lgtm
3 years, 6 months ago (2017-06-22 20:48:51 UTC) #12
skym
+napper for components/translate/OWNERS
3 years, 5 months ago (2017-06-27 14:44:07 UTC) #20
skym
Friendly ping napper@ :)
3 years, 5 months ago (2017-06-28 23:13:58 UTC) #21
napper
lgtm Sorry for the delay, this fell off my rader. lgtm
3 years, 5 months ago (2017-06-28 23:16:31 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2938813003/40001
3 years, 5 months ago (2017-06-28 23:17:12 UTC) #25
commit-bot: I haz the power
3 years, 5 months ago (2017-06-29 00:51:22 UTC) #28
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/212fbe9a6ef5c131b91d5719948c...

Powered by Google App Engine
This is Rietveld 408576698