Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(581)

Side by Side Diff: components/sync/protocol/user_event_specifics.proto

Issue 2942703002: [Sync] Make children messages of UserEventSpecifics' consistent use event suffix. (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « components/sync/protocol/proto_visitors.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2017 The Chromium Authors. All rights reserved. 1 // Copyright 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 // 4 //
5 // Sync protocol datatype extension for user events. 5 // Sync protocol datatype extension for user events.
6 6
7 // Update proto_value_conversions{.h,.cc,_unittest.cc} if you change 7 // Update proto_value_conversions{.h,.cc,_unittest.cc} if you change
8 // any fields in this file. 8 // any fields in this file.
9 9
10 syntax = "proto2"; 10 syntax = "proto2";
11 11
12 option optimize_for = LITE_RUNTIME; 12 option optimize_for = LITE_RUNTIME;
13 13
14 package sync_pb; 14 package sync_pb;
15 15
16 message FieldTrialEvent { 16 message FieldTrial {
17 message FieldTrial { 17 message FieldTrialPair {
18 optional fixed32 name_id = 1; 18 optional fixed32 name_id = 1;
19 optional fixed32 group_id = 2; 19 optional fixed32 group_id = 2;
20 } 20 }
21 repeated FieldTrial field_trials = 1; 21 repeated FieldTrialPair field_trial_pairs = 1;
22 } 22 }
23 23
24 // Language detection output. 24 // Language detection output.
25 message LanguageDetection { 25 message LanguageDetection {
26 message Language { 26 message Language {
27 // ISO 639 language code will be used. 27 // ISO 639 language code will be used.
28 optional string language_code = 1; 28 optional string language_code = 1;
29 // Whether the detected language is reliable, note this is determined by 29 // Whether the detected language is reliable, note this is determined by
30 // the CLD3. 30 // the CLD3.
31 optional bool is_reliable = 2; 31 optional bool is_reliable = 2;
(...skipping 47 matching lines...) Expand 10 before | Expand all | Expand 10 after
79 // other events belonged to. 79 // other events belonged to.
80 optional fixed64 session_id = 3; 80 optional fixed64 session_id = 3;
81 81
82 // 4-7 reserved for future scalars. 82 // 4-7 reserved for future scalars.
83 83
84 // Used for testing and debugging EventLog system. 84 // Used for testing and debugging EventLog system.
85 message Test {} 85 message Test {}
86 86
87 oneof event { 87 oneof event {
88 Test test = 8; 88 Test test = 8;
89 FieldTrialEvent field_trial_event = 9; 89 FieldTrial field_trial = 9;
90 LanguageDetection language_detection = 10; 90 LanguageDetection language_detection = 10;
bartekg 2017/06/16 04:02:30 An alternative would be to rename all fields in th
skym 2017/06/19 21:29:07 Done.
91 Translation translation = 11; 91 Translation translation = 11;
92 } 92 }
93 } 93 }
OLDNEW
« no previous file with comments | « components/sync/protocol/proto_visitors.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698