Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Unified Diff: components/translate/core/common/translation_logging_helper_unittest.cc

Issue 2942703002: [Sync] Make children messages of UserEventSpecifics' consistent use event suffix. (Closed)
Patch Set: Rebase Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/translate/core/common/translation_logging_helper.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/translate/core/common/translation_logging_helper_unittest.cc
diff --git a/components/translate/core/common/translation_logging_helper_unittest.cc b/components/translate/core/common/translation_logging_helper_unittest.cc
index d25247bba7b1dfe1803879d6b85793fc00de1a1a..62046de7af8093c028a59cf00e573c7bde878119 100644
--- a/components/translate/core/common/translation_logging_helper_unittest.cc
+++ b/components/translate/core/common/translation_logging_helper_unittest.cc
@@ -42,7 +42,8 @@ TEST(TranslationLoggingHelperTest, ConstructUserEventSpecifics) {
navigation_id, translation_event, &user_specifics);
EXPECT_TRUE(needs_logging);
EXPECT_EQ(user_specifics.navigation_id(), navigation_id);
- EqualTranslationProto(user_translation_event, user_specifics.translation());
+ EqualTranslationProto(user_translation_event,
+ user_specifics.translation_event());
}
// Tests that if user change the target language, the event is MANUAL.
@@ -65,7 +66,8 @@ TEST(TranslationLoggingHelperTest, UserManualEvent) {
navigation_id, translation_event, &user_specifics);
EXPECT_TRUE(needs_logging);
EXPECT_EQ(user_specifics.navigation_id(), navigation_id);
- EqualTranslationProto(user_translation_event, user_specifics.translation());
+ EqualTranslationProto(user_translation_event,
+ user_specifics.translation_event());
}
// Tests that we don't build unnecessary events.
@@ -84,4 +86,4 @@ TEST(TranslationLoggingHelperTest, DontBuildUnnecessaryEvent) {
EXPECT_FALSE(needs_logging);
}
-} // namespace translate
+} // namespace translate
« no previous file with comments | « components/translate/core/common/translation_logging_helper.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698