Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 2919983002: Remove Tab's |-url| property. (Closed)

Created:
3 years, 6 months ago by kkhorimoto
Modified:
3 years, 6 months ago
CC:
chromium-reviews, marq+watch_chromium.org, ios-reviews+chrome_chromium.org, noyau+watch_chromium.org, ios-reviews_chromium.org, asvitkine+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove Tab's |-url| property. Clients of the class should use |-lastCommittedURL| or |-visibleURL|. BUG=546208 Review-Url: https://codereview.chromium.org/2919983002 Cr-Commit-Position: refs/heads/master@{#476722} Committed: https://chromium.googlesource.com/chromium/src/+/0665658248db9bab31c319a1d11279b2bed3b6df

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -33 lines) Patch
M ios/chrome/browser/metrics/tab_usage_recorder_unittest.mm View 4 chunks +0 lines, -11 lines 0 comments Download
M ios/chrome/browser/tabs/tab.h View 1 chunk +0 lines, -5 lines 0 comments Download
M ios/chrome/browser/tabs/tab.mm View 1 chunk +0 lines, -7 lines 0 comments Download
M ios/chrome/browser/ui/browser_view_controller_unittest.mm View 4 chunks +0 lines, -10 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 8 (4 generated)
kkhorimoto
3 years, 6 months ago (2017-06-02 17:42:58 UTC) #2
Eugene But (OOO till 7-30)
lgtm
3 years, 6 months ago (2017-06-02 17:54:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2919983002/1
3 years, 6 months ago (2017-06-02 17:55:27 UTC) #5
commit-bot: I haz the power
3 years, 6 months ago (2017-06-02 18:09:32 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/0665658248db9bab31c319a1d112...

Powered by Google App Engine
This is Rietveld 408576698