Added NavigationManager::GetIndexOfItem().

Added NavigationManager::GetIndexOfItem().

This can be used in conjunction with GetForwardItems() and
GetBackwardItems() to navigate to arbitrary points in the session
history.

This CL also cleans up some DEPS exceptions.

BUG=454984
Review-Url: https://codereview.chromium.org/2915303002
Cr-Commit-Position: refs/heads/master@{#476821}
Committed: https://chromium.googlesource.com/chromium/src/+/aaf382944437a3ab5a18ffce1b0b57b62ac4d547

[kkhorimoto, 2017-06-02 17:58:18]

kkhorimoto@chromium.org changed reviewers:
+ eugenebut@chromium.org

[Eugene But (OOO till 7-30), 2017-06-02 18:08:11]

I'm so glad to see this DEPS cleanup.

https://codereview.chromium.org/2915303002/diff/1/ios/chrome/browser/tabs/tab.mm
File ios/chrome/browser/tabs/tab.mm (right):

https://codereview.chromium.org/2915303002/diff/1/ios/chrome/browser/tabs/tab...
ios/chrome/browser/tabs/tab.mm:1078: DCHECK(self.navigationManager);
No need to DCHECK before dereferencing the pointer.

https://codereview.chromium.org/2915303002/diff/1/ios/chrome/browser/tabs/tab...
ios/chrome/browser/tabs/tab.mm:1080: DCHECK_NE(index, NSNotFound);
NSNotFound is NSInteger, so it will never be equal to int on 64-bit platform
(int there is 32-bit and NSInteger is 64-bit)

https://codereview.chromium.org/2915303002/diff/1/ios/web/navigation/navigati...
File ios/web/navigation/navigation_manager_impl.h (right):

https://codereview.chromium.org/2915303002/diff/1/ios/web/navigation/navigati...
ios/web/navigation/navigation_manager_impl.h:124: int GetIndexOfItem(const
NavigationItem* item) const override;
Please add tests

https://codereview.chromium.org/2915303002/diff/1/ios/web/navigation/navigati...
File ios/web/navigation/navigation_manager_impl.mm (right):

https://codereview.chromium.org/2915303002/diff/1/ios/web/navigation/navigati...
ios/web/navigation/navigation_manager_impl.mm:272: return [session_controller_
indexOfItem:item];
NSNotFound will not survive this implicit case. We should return -1 instead.

https://codereview.chromium.org/2915303002/diff/1/ios/web/public/test/fakes/t...
File ios/web/public/test/fakes/test_navigation_manager.mm (right):

https://codereview.chromium.org/2915303002/diff/1/ios/web/public/test/fakes/t...
ios/web/public/test/fakes/test_navigation_manager.mm:84: return NSNotFound;
s/NSNotFound/-1

[kkhorimoto, 2017-06-02 18:28:58]

https://codereview.chromium.org/2915303002/diff/1/ios/chrome/browser/tabs/tab.mm
File ios/chrome/browser/tabs/tab.mm (right):

https://codereview.chromium.org/2915303002/diff/1/ios/chrome/browser/tabs/tab...
ios/chrome/browser/tabs/tab.mm:1078: DCHECK(self.navigationManager);
On 2017/06/02 18:08:08, Eugene But wrote:
> No need to DCHECK before dereferencing the pointer.

Done.

https://codereview.chromium.org/2915303002/diff/1/ios/chrome/browser/tabs/tab...
ios/chrome/browser/tabs/tab.mm:1080: DCHECK_NE(index, NSNotFound);
On 2017/06/02 18:08:08, Eugene But wrote:
> NSNotFound is NSInteger, so it will never be equal to int on 64-bit platform
> (int there is 32-bit and NSInteger is 64-bit)

Done.

https://codereview.chromium.org/2915303002/diff/1/ios/web/navigation/navigati...
File ios/web/navigation/navigation_manager_impl.h (right):

https://codereview.chromium.org/2915303002/diff/1/ios/web/navigation/navigati...
ios/web/navigation/navigation_manager_impl.h:124: int GetIndexOfItem(const
NavigationItem* item) const override;
On 2017/06/02 18:08:08, Eugene But wrote:
> Please add tests

Done.

https://codereview.chromium.org/2915303002/diff/1/ios/web/navigation/navigati...
File ios/web/navigation/navigation_manager_impl.mm (right):

https://codereview.chromium.org/2915303002/diff/1/ios/web/navigation/navigati...
ios/web/navigation/navigation_manager_impl.mm:272: return [session_controller_
indexOfItem:item];
On 2017/06/02 18:08:08, Eugene But wrote:
> NSNotFound will not survive this implicit case. We should return -1 instead.

Done.

https://codereview.chromium.org/2915303002/diff/1/ios/web/public/test/fakes/t...
File ios/web/public/test/fakes/test_navigation_manager.mm (right):

https://codereview.chromium.org/2915303002/diff/1/ios/web/public/test/fakes/t...
ios/web/public/test/fakes/test_navigation_manager.mm:84: return NSNotFound;
On 2017/06/02 18:08:08, Eugene But wrote:
> s/NSNotFound/-1

Done.

[Eugene But (OOO till 7-30), 2017-06-02 21:50:03]

lgtm

[kkhorimoto, 2017-06-02 21:51:51]

The CQ bit was checked by kkhorimoto@chromium.org

[commit-bot: I haz the power, 2017-06-02 21:52:22]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-02 21:55:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-02 21:55:52]

Try jobs failed on following builders:
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[kkhorimoto, 2017-06-02 22:05:02]

rebase

[kkhorimoto, 2017-06-02 22:05:03]

The CQ bit was checked by kkhorimoto@chromium.org

[kkhorimoto, 2017-06-02 22:05:03]

The patchset sent to the CQ was uploaded after l-g-t-m from
eugenebut@chromium.org
Link to the patchset: https://codereview.chromium.org/2915303002/#ps40001
(title: "rebase")

[commit-bot: I haz the power, 2017-06-02 22:05:38]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-02 22:35:22]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1496441103317680,
"parent_rev": "04968fe41e04b5f33305d9584561909760d9c3c7", "commit_rev":
"aaf382944437a3ab5a18ffce1b0b57b62ac4d547"}

[commit-bot: I haz the power, 2017-06-02 22:35:33]

Description was changed from

==========
Added NavigationManager::GetIndexOfItem().

This can be used in conjunction with GetForwardItems() and
GetBackwardItems() to navigate to arbitrary points in the session
history.

This CL also cleans up some DEPS exceptions.

BUG=454984
==========

to

==========
Added NavigationManager::GetIndexOfItem().

This can be used in conjunction with GetForwardItems() and
GetBackwardItems() to navigate to arbitrary points in the session
history.

This CL also cleans up some DEPS exceptions.

BUG=454984

Review-Url: https://codereview.chromium.org/2915303002
Cr-Commit-Position: refs/heads/master@{#476821}
Committed:
https://chromium.googlesource.com/chromium/src/+/aaf382944437a3ab5a18ffce1b0b...
==========

[commit-bot: I haz the power, 2017-06-02 22:35:34]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/aaf382944437a3ab5a18ffce1b0b...