Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Unified Diff: ios/chrome/browser/metrics/tab_usage_recorder_unittest.mm

Issue 2919983002: Remove Tab's |-url| property. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ios/chrome/browser/tabs/tab.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/browser/metrics/tab_usage_recorder_unittest.mm
diff --git a/ios/chrome/browser/metrics/tab_usage_recorder_unittest.mm b/ios/chrome/browser/metrics/tab_usage_recorder_unittest.mm
index 31672db7ce4483cc2514fefd37b40d67a4a9db8a..dbdb59ede190b48ccddeda15dafaa0fcbb191367 100644
--- a/ios/chrome/browser/metrics/tab_usage_recorder_unittest.mm
+++ b/ios/chrome/browser/metrics/tab_usage_recorder_unittest.mm
@@ -27,13 +27,11 @@
#endif
@interface TURTestTabMock : OCMockComplexTypeHelper {
- GURL _url;
GURL _lastCommittedURL;
GURL _visibleURL;
web::TestWebState _webState;
}
-@property(nonatomic, assign) const GURL& url;
@property(nonatomic, assign) const GURL& lastCommittedURL;
@property(nonatomic, assign) const GURL& visibleURL;
@property(nonatomic, readonly) web::WebState* webState;
@@ -41,12 +39,6 @@ @interface TURTestTabMock : OCMockComplexTypeHelper {
@end
@implementation TURTestTabMock
-- (const GURL&)url {
- return _url;
-}
-- (void)setUrl:(const GURL&)url {
- _url = url;
-}
- (const GURL&)lastCommittedURL {
return _lastCommittedURL;
}
@@ -134,7 +126,6 @@ id MockTab(bool inMemory) {
[OCMockObject mockForClass:[CRWWebController class]];
[[[tab_mock stub] andReturn:web_controller_mock] webController];
[[[tab_mock stub] andReturnBool:false] isPrerenderTab];
- [tab_mock setUrl:webUrl_];
[tab_mock setLastCommittedURL:webUrl_];
[tab_mock setVisibleURL:webUrl_];
[[[web_controller_mock stub] andReturnBool:inMemory] isViewAlive];
@@ -203,10 +194,8 @@ id MockTab(bool inMemory) {
TEST_F(TabUsageRecorderTest, CountNativePageLoadsBeforeEvictedTab) {
id tab_mock_a = MockTab(true);
id tab_mock_b = MockTab(false);
- [tab_mock_a setUrl:nativeUrl_];
[tab_mock_a setLastCommittedURL:nativeUrl_];
[tab_mock_a setVisibleURL:nativeUrl_];
- [tab_mock_b setUrl:nativeUrl_];
[tab_mock_b setLastCommittedURL:nativeUrl_];
[tab_mock_b setVisibleURL:nativeUrl_];
« no previous file with comments | « no previous file | ios/chrome/browser/tabs/tab.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698